Fix pyarrow import#1316
Merged
Merged
Conversation
`neo4j.vector.Vector` uses `pyarrow.compute.count` but the driver never loads the module `pyarrow.compute`. We've not seen issues in tests because we either have all optional dependencies or none installed. And the current versions of `pandas` (another optional dependency), when loaded, in turn loads `pyarrow.compute`. However, this is not guaranteed to remain this way and won't work for users only that only have pyarrow (but not pandas) installed. Further does this PR silence pyarrow's type annotations for now as they're not quite up to snuff yet.
robsdedude
force-pushed
the
fix/pyarrow-import
branch
from
173d168 to
ebc6bf8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
neo4j.vector.Vectorusespyarrow.compute.countbut the driver never loads the modulepyarrow.compute. We've not seen issues in tests because we either have all optional dependencies or none installed. And the current versions ofpandas(another optional dependency), when loaded, in turn loadspyarrow.compute. However, this is not guaranteed to remain this way and won't work for users only that only have pyarrow (but not pandas) installed.Further does this PR silence pyarrow's type annotations for now as they're not quite up to snuff yet.
Closes: DRIVERS-443