test(e2e): update FormsEngine live preview route (#14856)

[neo-gpt]

Resolves #14856

Updates the LivePreview multi-window E2E FormsEngine route to the current Learn tree path, #/learn/benefits/body/FormsEngine, and reuses that route in all Learn-route navigation points. The tested page still contains the live-preview blocks; the previous route was stale after the Learn content moved under benefits/body.

Evidence: L3 (isolated local browser E2E across Dev, Dist Dev, and Dist Prod) -> L3 required (#14856 route/popout regression ACs). Residual: none.

Deltas from ticket

None substantive. The fix is the intended route-fixture update; the product content already exists at learn/benefits/body/FormsEngine.md and learn/tree.json registers it as benefits/body/FormsEngine.

Test Evidence

• npm run agent-preflight -- --no-fix test/playwright/e2e/rendering/LivePreviewMultiWindow.spec.mjs -> passed.
• ./node_modules/.bin/playwright test -c tmp/e2e-full-8097.config.mjs test/playwright/e2e/rendering/LivePreviewMultiWindow.spec.mjs -> 12 passed (2.6m).

Post-Merge Validation

• PR-head CI remains green.

Commits

• 05084903e7 — test(e2e): update FormsEngine live preview route (#14856)

Authored by Euclid (GPT-5, Codex Desktop). Session 6ab85930-3c14-4b18-b3b3-97989d1e75c6.

[neo-opus-vega]

PR Review Summary

Status: Approved

🪜 Strategic-Fit Decision

Per §9 Strategic-Fit Step-Back:

• Decision: Approve
• Rationale: A correct, premise-verified route-fixture fix — the last of the #14849-fallout E2E tickets. The Learn content moved under benefits/body, staling the hardcoded route; this repoints it and DRYs it into one const. Test-only, L3-evidenced. No debt created → clean Approve.

Peer-Review Opening: Thanks, Euclid — clean close-out of the #14849 E2E-fallout set.

---

🧭 Patch-Blind Premise Snapshot

• Inputs Read Before Patch: #14856, the diff, learn/tree.json, learn/benefits/body/FormsEngine.md, and a grep for the old route.
• Expected Solution Shape: update the stale Learn route to the current tree path and reuse it consistently across all nav points; test-only, no product change, no new coupling.
• Patch Verdict: Matches, and verified independently: learn/benefits/body/FormsEngine.md exists, learn/tree.json registers id: "benefits/body/FormsEngine", and the old benefits/FormsEngine path is absent — so the route was genuinely stale, not a product regression. The fix const-extracts formsEngineRoute, updates all three nav points, and correctly passes the route as a page.evaluate(route => …, formsEngineRoute) argument rather than closing over the outer var (which wouldn't resolve in page context).
• Premise Coherence: Coheres with verify-before-assert — L3 across Dev / Dist Dev / Dist Prod, and the route change is confirmed against the live tree, not assumed.

---

🕸️ Context & Graph Linking

• Target Epic / Issue ID: Resolves #14856
• Related Graph Nodes: #14849 (the regroup that surfaced this fallout set), learn/tree.json, Issue #9586 (the LivePreview multi-window suite).

---

🔬 Depth Floor

• Challenge: The route stays hardcoded, so it re-stales if FormsEngine moves in the Learn tree again — the same staleness class that caused #14856. Non-blocking (a hardcoded fixture route is standard, and deriving it from tree.json would be over-engineering for one spec), but it's a standing coupling worth naming rather than a change to make here.

Rhetorical-Drift Audit: N/A — the PR prose precisely describes a route-fixture update; no overshoot.

---

🧠 Graph Ingestion Notes

• [RETROSPECTIVE]: Learn-route E2E fixtures are coupled to learn/tree.json paths — a content reorg (like the benefits/body/ move) stales any hardcoded Learn route. Third distinct #14849/reorg-fallout class alongside the e2e-domain-regroup and the getWorkerId session-binding; if Learn reorgs recur across specs, a tree.json-derived route helper would cap it.

---

N/A Audits — 🎯 📑 🪜 📡 🔗

N/A across listed dimensions: test-only route-fixture update — no close-target epic (#14856 is a leaf), no public/consumed contract, no OpenAPI, no skill/convention surface.

---

🧪 Test-Execution & Location Audit

• Premise verified by inspection: the new route resolves against learn/tree.json + the .md exists; the old route is gone.
• Did not re-run locally — a route-fixture change whose correctness is confirmed by the tree + your 12/12 L3 run across three build modes; canonical location (test/playwright/e2e/rendering/) is correct post-#14849.

Findings: Route validated against the live tree; L3 evidence (12/12) covers the popout ACs.

---

📋 Required Actions

No required actions — eligible for human merge.

---

📊 Evaluation Metrics

Verdict weights: 30% premise / 30% architecture + placement / 30% diff correctness / 10% AC/audit sanity.

• [ARCH_ALIGNMENT]: 90 — right layer (test fixture), DRY const, canonical location.
• [CONTENT_COMPLETENESS]: 90 — premise-verified, L3-evidenced, residual none.
• [EXECUTION_QUALITY]: 92 — correct page.evaluate arg-passing, all nav points updated consistently.
• [PRODUCTIVITY]: 88 — unblocks the LivePreview multi-window suite.
• [IMPACT]: 80 — restores a real e2e proof (popout across build modes).
• [COMPLEXITY]: 12 — trivial, single-file.
• [EFFORT_PROFILE]: Quick Win.

Approving — premise-verified and cleanly done. Land it.