Skip to content

fix: case studies filter tabs no longer break back button #4896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rahulhgdev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: case studies filter tabs no longer break back button #4896

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions src/components/pages/case-studies/cards/cards.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,12 @@ const Cards = ({ items, categories }) => {

applyHash();
window.addEventListener('hashchange', applyHash);
window.addEventListener('popstate', applyHash);

return () => window.removeEventListener('hashchange', applyHash);
return () => {
window.removeEventListener('hashchange', applyHash);
window.removeEventListener('popstate', applyHash);
};
}, [categories]);

const filteredByCategory = useMemo(
Expand All @@ -108,8 +112,15 @@ const Cards = ({ items, categories }) => {
return filteredByCategory.filter((item) => item.title?.toLowerCase().includes(q));
}, [filteredByCategory, searchQuery]);

const handleCategoryClick = useCallback((slug, featuredCaseStudy) => {
const handleCategoryClick = useCallback((event, slug, featuredCaseStudy) => {
event.preventDefault();
setActiveCategory({ slug, featuredCaseStudy });

if (typeof window !== 'undefined') {
const baseUrl = window.location.pathname + window.location.search;
const hash = slug === 'all' ? '' : `#${slug}`;
window.history.replaceState(null, '', `${baseUrl}${hash}`);
}
}, []);

return (
Expand Down Expand Up @@ -173,7 +184,7 @@ const Cards = ({ items, categories }) => {
? 'text-white lg:border-green-45'
: 'text-gray-new-60 lg:border-transparent'
)}
onClick={() => handleCategoryClick(slug, featuredCaseStudy)}
onClick={(event) => handleCategoryClick(event, slug, featuredCaseStudy)}
>
<span>{label}</span>
{isActive && (
Expand Down