BUG: Proxy class building destroys nested attributes or enums

[mficzel]

Is there an existing issue for this?

• I have searched the existing issues

Current Behavior

Proxy Building seems to destroy nested Attributes. This is an additional reason why ORM Attributes cannot yet be used. However it is important that fixing this will not enable ORM Attributes yet.

When the following Attributes are added to a class that is proxied:

#[Flow\Entity]
#[ORM\Table(uniqueConstraints: [
    new ORM\UniqueConstraint(name: 'nodeData_name_value', columns: ["nodedata", "name", "value"])
])]

the following code is generated in the proxy class

#[Flow\Entity]
#[\Doctrine\ORM\Mapping\Table(uniqueConstraints: array (
    0 =>
        \Doctrine\ORM\Mapping\UniqueConstraint::__set_state(array(
            'name' => 'nodeData_name_value',
            'columns' =>
                array (
                    0 => 'nodedata',
                    1 => 'name',
                    2 => 'value',
                ),
            'fields' => NULL,
            'options' => NULL,
        )),
))]

Expected Behavior

The generated code should be similar to the original

#[Flow\Entity]
#[ORM\Table(uniqueConstraints: [
   new ORM\UniqueConstraint(name: 'nodeData_name_value', columns: ["nodedata", "name", "value"])
])]

Steps To Reproduce

No response

Environment

- Flow: 8.3+ 8,4+
- PHP: 8.0+

Anything else?

Nested Attributes are supported from PHP 8.1 so one could say that we should only support this starting from Neos 8.4 that has PHP 8.2 as minimal requirement.

The attributes of proxy classes are rendered here:

• Class Attributes \Neos\Flow\ObjectManagement\Proxy\Compiler::renderAttribute
• Method Attributes \Neos\Flow\ObjectManagement\Proxy\ProxyMethodGenerator::buildAttributesCode

[mficzel]

Technical reason is that starting from php 8.1 attributes may contain constant expressions as arguments which may be other attributes aswell. However the code generated by var_export is not a constant expression.

[mhsdesign]

The issue of not supporting nested attributes also shows when attempting to proxy a method that contains those either via AOP or security.

The reason for this is our home-made code in Neos\Flow\ObjectManagement\Proxy\ProxyMethodGenerator::buildAttributesCode which is stated to be just temporary until laminas laminas/laminas-code#145 is released - if ever. But even the (stale) core change in laminas does not support nested attribute generation yet.

Example:

#[SomeAttributeMaybeForQueryMapping(
    nested: new SomeOtherAttribute()
)]
public function indexAction()
{
}

Failed rendering proxy method indexAction because an attribute contained an unsupported value type (SomeOtherAttribute)

[mficzel]

@mhsdesign I think this should be solved with #3512 aswell.

[mhsdesign]

Thank you ❤️ that looks good:) When i looked at the problem i feared that we might need to iterate through the constructor arguments and attempt to recreate their code representation values ... but there seems no way around this as we create the proxy by looking at the reflection code which is just not the bare code anymore ... so thanks:)

Should we upmerge and release that and close this issue then?

[mficzel]

@mhsdesign one topic we should look into is attributes for method parameters. But this should be done separately and might be a feature.

Upmerge and release of this should be done together with #3508