TASK: Harmonize semantics of Neos\Utility\TypeHandling with PHP 8 typ…#3567
Open
vcg-development wants to merge 3 commits into
Open
TASK: Harmonize semantics of Neos\Utility\TypeHandling with PHP 8 typ…#3567vcg-development wants to merge 3 commits into
vcg-development wants to merge 3 commits into
Conversation
Member
|
This looks like the wrong target branch was selected – too many commits in the PR. |
…e system semantics Use new Harmonized semantics in Reflection Service
vcg-development
force-pushed
the
task/harmonizeSemantics
branch
from
June 5, 2026 11:53
93f7b5e to
1b128bd
Compare
dlubitz
reviewed
Jun 5, 2026
Comment on lines
+33
to
+47
| /** | ||
| * A type pattern to detect scalar types. | ||
| */ | ||
| const SCALAR_TYPE_PATTERN = '/^(?:int|float|bool|string)$/'; | ||
|
|
||
| /** | ||
| * @var array<string> | ||
| */ | ||
| protected static $builtInTypes = ['null', 'array', 'object', 'resource', 'never', 'void', 'self', 'parent', 'static']; | ||
|
|
||
| /** | ||
| * @var array<string> | ||
| */ | ||
| protected static $builtInTypeAliases = ['mixed', 'iterable']; | ||
|
|
Contributor
There was a problem hiding this comment.
I wonder about the mix here between regex and array configuration.
Fix check if backslash is already present at start of string in reflectClassMethod leading slash check
Author
|
I think I am not informed enough to decide how the code should function here. Could someone else please take over this PR that has more theoretical knowledge of how php works here and knows how the reflections should be handled here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIXES: #2945