Skip to content

Commit 8d61d0e

Browse files
committed
fix: Exclude S-frames from failed_frames counter
S-frames update lastSlow data (merged into I/P frames) but don't set parsing_success=true since they don't create separate CSV rows. This caused them to be incorrectly counted as failed frames. Fix excludes S-frames from failed_frames increment while keeping the correct behavior of merging S-frame data into subsequent I/P frames. Addresses coderabbitai feedback: - src/parser/frame.rs lines 299-334, 507-513 - src/main.rs lines 1563-1564, 2031-2056 Tested: CLI and CRATE output identical (MD5: 3940efce93a1ef6f48248233357b74cc)
1 parent 8d9a402 commit 8d61d0e

2 files changed

Lines changed: 6 additions & 2 deletions

File tree

src/main.rs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2048,7 +2048,9 @@ fn parse_frames(
20482048
_ => {}
20492049
};
20502050

2051-
if !parsing_success {
2051+
// S-frames don't set parsing_success but are processed successfully
2052+
// (they update lastSlow data merged into I/P frames)
2053+
if !parsing_success && frame_type != 'S' {
20522054
stats.failed_frames += 1;
20532055
}
20542056

src/parser/frame.rs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -504,7 +504,9 @@ pub fn parse_frames(
504504
_ => {}
505505
};
506506

507-
if !parsing_success {
507+
// S-frames don't set parsing_success but are processed successfully
508+
// (they update lastSlow data merged into I/P frames)
509+
if !parsing_success && frame_type != 'S' {
508510
stats.failed_frames += 1;
509511
}
510512

0 commit comments

Comments
 (0)