Skip to content

Commit db57cc3

Browse files
committed
fix: align release notes date with binary output and prevent race condition
- Use git commit date (via 'git log') instead of release creation timestamp to match VERGEN_GIT_COMMIT_DATE shown in binary (-V output) - Ensures consistency: release notes show actual commit date, not when release was created - Add build-release-assets to upload-release-assets job dependencies to prevent race condition where upload tries to access artifacts before they exist - Workflow now correctly waits for both jobs before attempting artifact operations
1 parent 26778a1 commit db57cc3

1 file changed

Lines changed: 6 additions & 3 deletions

File tree

.github/workflows/release.yml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -116,8 +116,11 @@ jobs:
116116
GIT_SHA="${{ github.sha }}"
117117
GIT_SHA_SHORT="${GIT_SHA:0:7}"
118118
119-
# Format version string
120-
BUILD_INFO="${SEMVER} ${GIT_SHA_SHORT} (${{ github.event.release.created_at }})"
119+
# Get git commit date from repository (matches VERGEN_GIT_COMMIT_DATE in binary)
120+
GIT_COMMIT_DATE=$(git log -1 --format=%ci "${{ github.sha }}" | cut -d' ' -f1)
121+
122+
# Format version string to match binary output
123+
BUILD_INFO="${SEMVER} ${GIT_SHA_SHORT} (${GIT_COMMIT_DATE})"
121124
122125
echo "Extracted version: $BUILD_INFO"
123126
@@ -128,7 +131,7 @@ jobs:
128131
129132
upload-release-assets:
130133
name: Upload Assets to GitHub Release
131-
needs: determine-version
134+
needs: [build-release-assets, determine-version]
132135
runs-on: ubuntu-latest
133136
steps:
134137
- name: Download all artifacts

0 commit comments

Comments
 (0)