sample pixels from all data in variable-resolution batches#2772
Merged
brentyi merged 10 commits intonerfstudio-project:mainfrom Apr 24, 2025
Merged
sample pixels from all data in variable-resolution batches#2772brentyi merged 10 commits intonerfstudio-project:mainfrom
brentyi merged 10 commits intonerfstudio-project:mainfrom
Conversation
Contributor
Author
|
@brentyi I believe this (old) MR is still needed to fix the Any chance this could get merged so we don't have to continue keeping it up to date with main in parallel? |
brentyi
approved these changes
Apr 24, 2025
Collaborator
brentyi
left a comment
brentyi
left a comment
There was a problem hiding this comment.
Thanks @decrispell for the bump! I did a pass and this looks reasonable to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bring the behavior of collate_image_dataset_batch_list in line with that of collate_image_dataset_batch by sampling pixels from all data in the batch, not just "image".