fix: remove safeguards for parsing colmap data#3613
fix: remove safeguards for parsing colmap data#3613Yubel426 wants to merge 2 commits intonerfstudio-project:mainfrom
Conversation
|
This is incorrect. #3612 is correct. |
|
Hi @f-dy, for the perspective models—"SIMPLE_PINHOLE", "PINHOLE", "SIMPLE_RADIAL", and "RADIAL"—their k4 parameter is correctly set to 0 when reading the parameters. I'm not sure what the purpose of this error check is; please let me know if I've misunderstood anything. It’s possible that k4 doesn’t support fisheye either; a new PR is needed here. |
|
@Yubel426 Imagine you have some random function over [a;b] and you have a polynom which approximates it: Instead you need to build a proper new approximation, not just dropping one coefficient from the reacher one. |
Fix #3611. The safeguards introduced in #3381 makes datasets with non-zero k4 coefficient such as fisheye unusable. When reading camera distortion coefficients such as OPENCV camera, k4 is correctly assigned as the fourth-order radial distortion coefficient rather than the fourth coefficient. Therefore, the safeguards can be removed.