Clean | Remove timm dependency#3637
Open
Totoro97 wants to merge 2 commits intonerfstudio-project:mainfrom
Open
Clean | Remove timm dependency#3637Totoro97 wants to merge 2 commits intonerfstudio-project:mainfrom
timm dependency#3637Totoro97 wants to merge 2 commits intonerfstudio-project:mainfrom
Conversation
akristoffersen
previously requested changes
Apr 21, 2025
Contributor
akristoffersen
left a comment
akristoffersen
left a comment
There was a problem hiding this comment.
Nice catch. I think you might also need to update the pixi files as well?
Author
|
@akristoffersen Thank for your the review! There is no |
Contributor
|
ah sorry, I meant |
|
+1 here. Trying to use this with the huggingface transformers package and that uses a later version of timm. |
kerrj
approved these changes
May 12, 2025
Collaborator
kerrj
left a comment
kerrj
left a comment
There was a problem hiding this comment.
also looks good to me! Didn't realize timm is never used inside the repo, oops
kerrj
requested changes
May 12, 2025
Collaborator
kerrj
left a comment
kerrj
left a comment
There was a problem hiding this comment.
Ah sorry I misunderstood, Alex is right that pixi.lock needs to be regenerated.
|
Hello! Thank you for all the work here. Are there any updates on merging this? I am also encountering the same problem |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I searched the codebase and found that timm is actually not used. It seems this dependency was introduced in the following PR: #2284. However, I couldn’t find any place where timm is actually referenced 🤔
One reason I’d like to remove this dependency is that I need to install another package that also requires timm, but with a much higher version, which leads to a version conflict.