Skip to content

fix: handle image_rename_map key mismatch in colmap_to_json (issue #3759) #3761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vanhci wants to merge 1 commit into from
+13 −1
Closed

fix: handle image_rename_map key mismatch in colmap_to_json (issue #3759) #3761

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion nerfstudio/process_data/colmap_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,19 @@ def colmap_to_json(

name = im_data.name
if image_rename_map is not None:
name = image_rename_map[name]
# COLMAP stores image names relative to the reconstruction directory
# (e.g. "images/rig1/front/imageN.jpg"), but image_rename_map keys
# are relative to the data directory (e.g. "rig1/front/imageN.jpg").
# Try the direct lookup first, then strip the "images/" prefix.
if name in image_rename_map:
name = image_rename_map[name]
elif name.startswith("images/") and name[7:] in image_rename_map:
name = image_rename_map[name[7:]]
else:
raise KeyError(
f"Image name '{name}' not found in image_rename_map. "
f"Available keys (first 5): {list(image_rename_map.keys())[:5]}"
)
name = Path(f"./images/{name}")

frame = {
Expand Down
Loading