Fix c_int to u32 type mismatch in c-wrapper-crate FFI wrapper#38
Merged
Conversation
…turn type Co-authored-by: 15168316096 <45781590+15168316096@users.noreply.github.com>
Fix c_int to u32 type mismatch in c-wrapper-crate FFI wrapper
XuJiandong
approved these changes
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
value()returnsu32but wrapsbar()which returnsc_int(i32). Theas u32cast silently converts negative return values — a-1error code becomes4294967295. Since this is a scaffold template, downstream contracts inherit the bug.value()return type fromu32toi32to match the FFI signatureas u32cast💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.