Skip to content

Merge 2.44.0 into master#841

Merged
joii2020 merged 5 commits into
masterfrom
develop
Jun 29, 2026
Merged

Merge 2.44.0 into master#841
joii2020 merged 5 commits into
masterfrom
develop

Conversation

@joii2020

Copy link
Copy Markdown
Collaborator

No description provided.

yfeng2824 and others added 5 commits June 23, 2026 14:46
…ite (#837)

Bumps [http-proxy-middleware](https://github.com/chimurai/http-proxy-middleware) from 2.0.9 to 2.0.10.
- [Release notes](https://github.com/chimurai/http-proxy-middleware/releases)
- [Changelog](https://github.com/chimurai/http-proxy-middleware/blob/v2.0.10/CHANGELOG.md)
- [Commits](chimurai/http-proxy-middleware@v2.0.9...v2.0.10)

---
updated-dependencies:
- dependency-name: http-proxy-middleware
  dependency-version: 2.0.10
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* docs: add AI metadata to priority pages

* address feedback
@vercel

vercel Bot commented Jun 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nervos-ckb-docs Ready Ready Preview, Comment Jun 29, 2026 2:53am

Request Review

@humble-little-bear

Copy link
Copy Markdown
Contributor

Factual-accuracy review — PR #841 ("Merge 2.44.0 into master")

I reviewed the in-scope changes (added/modified lines under website/docs/**) for factual accuracy against the CKB source and RFCs.

The changes in this PR fall into two categories, both outside the factual-review scope:

  • Frontmatter metadata additions (description, tags, audience, related, difficulty, last_reviewed) across 15 docs files.
  • Grammar / typo cleanups (e.g. JavascriptJavaScript, the thethe, usecasesuse cases, a examplean example).

I spot-checked the few lines that touch technical content; all are accurate:

  • "1 CKB = 10^8 Shannons" (dapp/transfer-ckb.mdx) — correct.
  • "proof-of-work" consensus (ckb-fundamentals/nervos-blockchain.md, getting-started/how-ckb-works.mdx) — correct (CKB uses Eaglesong PoW).
  • Transaction fields cell_deps, header_deps, inputs, witnesses, outputs, outputs_data (tech-explanation/transaction.md) — match RFC 0022.

No factual claims were introduced or altered that contradict authoritative sources.

LGTM, No factual-review issues found.

@humble-little-bear

Copy link
Copy Markdown
Contributor

CKB Docs Writing Review

Summary

This PR (merging 2.44.0 into master) is almost entirely (a) new YAML frontmatter metadata blocks (description, tags, audience, related, difficulty, last_reviewed) and (b) copyediting fixes. From an editorial standpoint the prose changes are clean, correct improvements — they fix real typos, grammar, and terminology issues without introducing new ones. Terminology (Lock Script, Type Script, Cell, Shannon, CKB-VM, CKByte) is used consistently with the existing glossary and style guide.

Notable fixes (all good)

  • nervos-blockchain.md: JavascriptJavaScript; fullwidth comma ,. ✅
  • sdk-and-devtool/ccc.mdx: TypescriptTypeScript; a examplean example. ✅
  • getting-started/how-ckb-works.mdx: transacitontransaction; the the methodthe method; users’suser’s. ✅
  • getting-started/rpcs.mdx: commands usescommand uses the; fullwidth colon :; reflowed the get_transaction sentence for readability. ✅
  • script/intro-to-script.mdx: usecasesuse cases; owner shipownership; changes of a Cell is validchanges to a Cell are valid. ✅
  • dapp/write-message.mdx, dapp/transfer-ckb.mdx, dapp/create-*.mdx: cleaned up the recap intros and several run-on sentences; the value handle are mostly donevalues are mostly handled. ✅
  • script/rust/rust-quick-start.mdx: it will not diving into in-depth detailsit will not go into deep detail. ✅

Findings

Only minor, optional notes — none block merge:

  • getting-started/how-ckb-works.mdx:L120 (context, not changed by this PR): There’re two main types of Scripts: — the contraction "There're" is informal for reference docs; consider "There are" in a future pass. [confidence: low]
  • Frontmatter related: entries are internal doc paths (e.g. tech-explanation/cell, tech-explanation/capacity in cell-model.md; script/js/js-vm in simple-lock.mdx). Worth a quick confirmation that each path resolves to an existing doc id, since these now feed cross-references. [confidence: low]

Terminology cross-checks

  • Shannon / CKByte / Lock Script / Type Script / CKB-VM: all match the glossary's title-case and spelling conventions in both prose and the new description fields. No inconsistencies found.
  • CKBytes (plural) in nervos-blockchain.md description is consistent with existing usage.

Questions

  • None blocking. The new metadata fields (audience, related, difficulty, last_reviewed) are custom frontmatter; confirming the site config/schema accepts them is a build concern outside this editorial review.

Overall: LGTM from an editorial standpoint — the writing changes are solid improvements.

@joii2020
joii2020 merged commit f8fc174 into master Jun 29, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants