Coalesce duplicate CCH LND invoice trackers#1556
Open
jjyr wants to merge 3 commits into
Open
Conversation
jjyr
marked this pull request as ready for review
July 15, 2026 05:03
Contributor
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Repeated
TrackInvoicemessages could enqueue or start multiple LND tracker tasks for the same payment hash. The duplicate work consumed bounded tracker slots and could grow the waiting queue without adding coverage. Keeping a set of queued and active invoice hashes makes tracking idempotent while preserving retries for genuine tracker failures.Validation
cargo fmt --all -- --checkcargo nextest run -p fnn --features sqlite -E 'test(/test_(duplicate_tracking_requests_are_coalesced|stopped_tracker_is_not_requeued_after_failure)/)'cargo clippy --all-targets --features sqlite -p fnn -- -D warnings