Skip to content

Add pre-commit hooks#3849

Open
terhorstd wants to merge 3 commits into
nest:mainfrom
terhorstd:add-pre-commit-hooks
Open

Add pre-commit hooks#3849
terhorstd wants to merge 3 commits into
nest:mainfrom
terhorstd:add-pre-commit-hooks

Conversation

@terhorstd
Copy link
Copy Markdown
Contributor

Preparatory work for #3848:

  • add more linters to .pre-commit-config.yaml → tool coverage
  • configure tools to actually scan all files → file coverage
  • keeps failing tests minimal, but fixes smaller problems → base issue coverage

After this PR we can start to remove the ignores one by one and proceed with #3848.

@terhorstd terhorstd added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels May 26, 2026
@heplesser
Copy link
Copy Markdown
Contributor

Thanks for starting this. But the checks seem to generate insane numbers of false positives, likely due to the rather convoluted way in which we construct the nest module. Also, coverage seems to include the test files themselves, which seems counterproductive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants