Add pre-commit hooks#3849
Open
terhorstd wants to merge 3 commits into
Open
Conversation
Contributor
|
Thanks for starting this. But the checks seem to generate insane numbers of false positives, likely due to the rather convoluted way in which we construct the nest module. Also, coverage seems to include the test files themselves, which seems counterproductive. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preparatory work for #3848:
.pre-commit-config.yaml→ tool coverageAfter this PR we can start to remove the ignores one by one and proceed with #3848.