feat: Add type and CRUD options in generate command#3275
Merged
kamilmysliwiec merged 2 commits intonestjs:masterfrom Apr 16, 2026
Merged
feat: Add type and CRUD options in generate command#3275kamilmysliwiec merged 2 commits intonestjs:masterfrom
kamilmysliwiec merged 2 commits intonestjs:masterfrom
Conversation
4 tasks
There was a problem hiding this comment.
Pull request overview
This PR updates the Nest CLI generate command to recognize and forward --type and --crud flags to the underlying resource schematic, addressing issue #3229 where these flags were rejected as unknown options.
Changes:
- Add
--typeand--crudoptions tonest generate. - Forward
typeandcrudvalues into the schematic option list passed to@angular-devkit/schematics-cli.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yogeshwaran-c
added a commit
to yogeshwaran-c/nest-cli
that referenced
this pull request
Apr 17, 2026
Backports the master-branch fix for nestjs#3229 (PR nestjs#3275) to v12.0.0. The `@nestjs/schematics` resource generator defines `--type` and `--crud` options in its schema.json, but the v12 CLI does not register either flag on the `generate` command. Running: nest g resource users --type rest --crud exits with "error: unknown option '--type'" even though the schematic itself would handle both flags correctly. - register `--type [type]` and `--crud` on the generate command - forward both into the generate action and on to the schematic - only forward `--crud` when explicitly passed (avoid toggling default behavior on users who never opted in) The master-branch PR noted that "no automated tests were added because there are no existing e2e tests for generate resource" — this PR adds a focused unit spec for `GenerateAction` covering forwarding of the new options individually and together.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
throws:
Even though --type and --crud are defined in the resource/schema.json schematic.
Issue Number: #3229
What is the new behavior?
Generates:
Does this PR introduce a breaking change?
Other information