Refactor newsletter form submission to use Fetch API#124
Closed
apoorvpathak wants to merge 1 commit intonestjs:masterfrom
Closed
Refactor newsletter form submission to use Fetch API#124apoorvpathak wants to merge 1 commit intonestjs:masterfrom
apoorvpathak wants to merge 1 commit intonestjs:masterfrom
Conversation
Author
|
hey @kamilmysliwiec when you have some time, could you please have a look at this PR? thanks! |
micalevisk
approved these changes
Mar 27, 2025
Member
|
We're in the middle of a major redesign - this website will be entirely revamped soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the legacy
XMLHttpRequestwith the modernFetch APIfor handling the newsletter form submission. The update improves code readability, maintainability, and aligns with modern JavaScript best practices.Changes:
Replaced
XMLHttpRequestwithfetchandasync/awaitKept all existing functionality intact
Improved error handling with
try-catchI tried to keep the changes minimal as this is my first-ever PR to this project. In the future, I plan to enhance the newsletter submission by:
Adding a loading spinner for better user experience
Displaying an error message if something goes wrong while submitting the email
Looking forward to any feedback and Let me know if you need any refinements!