Skip to content

Commit 0043004

Browse files
committed
Add TODO comment for future improvement.
Signed-off-by: Cesar Talledo <cesar.talledo@docker.com>
1 parent b06dcfb commit 0043004

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

mount/service.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,11 @@ var SysfsMounts = []string{
5050

5151
// IsSysboxfsMount checks if the given path is at or under a sysbox-fs mount
5252
func IsSysboxfsMount(path string) bool {
53+
54+
// TODO: don't just check by path name; check that the given path is in fact
55+
// on a sysbox-fs managed mount. This likely requires dispatching an nsenter
56+
// agent to the container's mount ns to perform the check.
57+
5358
for _, mountPath := range ProcfsMounts {
5459
if strings.HasPrefix(path, mountPath+"/") || path == mountPath {
5560
return true

0 commit comments

Comments
 (0)