Fail if containerd version cannot be retrieved.#151
Open
nclaeys wants to merge 1 commit into
Open
Conversation
We ran into this issue where sysbox silently assumed containerd did not support user namespaces because of a transient connection issue when fetching the containerd version. This makes the the node unusable as sysbox-runc is not configured in containerd and thus the node is unusable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not silently fail when retrieving the containerd version.
We ran into this exact issue: sysbox silently assumed containerd did not support user namespaces because of a transient connection issue when fetching the containerd version.
Because of this the node unusable as sysbox-runc is not configured in containerd, which makes the node is unusable.