Skip to content

Next release#1686

Merged
jokob-sk merged 3 commits into
mainfrom
next_release
Jun 21, 2026
Merged

Next release#1686
jokob-sk merged 3 commits into
mainfrom
next_release

Conversation

@jokob-sk

@jokob-sk jokob-sk commented Jun 21, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Bug Fixes

    • Optimized loading skeleton overlay to disappear faster during content loads.
    • Improved device connectivity metadata handling in MQTT discovery messages.
  • Style

    • Enhanced loading skeleton visual presentation in data tables.

@coderabbitai

coderabbitai Bot commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 119d74fe-d686-4f6e-a861-65700c1d771e

📥 Commits

Reviewing files that changed from the base of the PR and between d996fc7 and 07b731f.

📒 Files selected for processing (3)
  • front/css/app.css
  • front/plugins/_publisher_mqtt/mqtt.py
  • front/pluginsCore.php

📝 Walkthrough

Walkthrough

The PR makes two independent fixes: the plugins page skeleton overlay drops background:inherit from its container and reduces fade-out from 250ms to 50ms, with a new CSS rule setting var(--skel-bg) for .skel-table-box in relevant selectors. In the MQTT publisher, MAC connections metadata is moved from binary_sensor/sensor device blocks to the device_tracker device block.

Changes

Plugin Table Skeleton Overlay

Layer / File(s) Summary
Skeleton background and fade-out timing
front/pluginsCore.php, front/css/app.css
Removes background:inherit from the skeleton container div, reduces initComplete fade-out from 250ms to 50ms, and adds a CSS rule applying var(--skel-bg) to .skel-table-box inside #pluginsPage and .plugin-content.

MQTT Publisher MAC Connections Relocation

Layer / File(s) Summary
Move MAC connections from sensor to device_tracker block
front/plugins/_publisher_mqtt/mqtt.py
connections_snippet is now precomputed before type branching; the connections field is removed from binary_sensor/sensor device objects and added to the device_tracker device object.

Possibly related PRs

  • netalertx/NetAlertX#1683: Also modifies sensor_config.initialize_message() in mqtt.py to change conditional inclusion of the connections field in binary_sensor/sensor device blocks, directly overlapping with the same code section.
  • netalertx/NetAlertX#1684: Also modifies the DataTable skeleton overlay behavior in front/pluginsCore.php, touching the same fade-out and rendering logic.

Poem

🐇 Hop, hop — the skeleton fades away so fast,
No more lingering background from the past!
The tracker now holds the MAC address tight,
While sensors travel a little more light.
With 50ms blinks, the table's plain,
This rabbit cleaned the UI up again! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title 'Next release' is too generic and vague; it does not describe the specific changes in the pull request (CSS skeleton styling, MQTT device connections, and DataTable skeleton behavior). Replace with a specific title that summarizes the main changes, such as 'Move MAC connections metadata from binary_sensor to device_tracker' or 'Update skeleton UI styling and animation timing'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch next_release

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jokob-sk jokob-sk merged commit bd2c6cb into main Jun 21, 2026
6 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant