Skip to content

ND4.1: Validation of cisco.nd.rest module#503

Open
sivakasi-cisco wants to merge 12 commits into
netascode:developfrom
sivakasi-cisco:changes_for_nd_rest
Open

ND4.1: Validation of cisco.nd.rest module#503
sivakasi-cisco wants to merge 12 commits into
netascode:developfrom
sivakasi-cisco:changes_for_nd_rest

Conversation

@sivakasi-cisco

@sivakasi-cisco sivakasi-cisco commented Jul 24, 2025

Copy link
Copy Markdown

Related Issue(s)

CiscoDevNet/ansible-dcnm#475

Related Collection Role : * [ ] cisco.nac_dc_vxlan.validate

  • [- ] cisco.nac_dc_vxlan.validate
  • cisco.nac_dc_vxlan.dtc.create
  • cisco.nac_dc_vxlan.dtc.deploy
  • cisco.nac_dc_vxlan.dtc.remove
  • other

Related Data Model Element: * [ ] other

  • vxlan.fabric
  • vxlan.global
  • vxlan.topology
  • vxlan.underlay
  • vxlan.overlay
  • vxlan.overlay_extensions
  • vxlan.policy
  • vxlan.multisite
  • defaults.vxlan
  • [ - ] other

Proposed Changes

The ND Rest Module needs to be validated against our VXLAN as Code collection to ensure that everywhere our DCNM Rest Module is used we can replace it and it works.

Replace all instances of cisco.dcnm.dcnm_rest with cisco.nd.nd_rest
https://github.com/search?q=repo%3Anetascode%2Fansible-dc-vxlan+dcnm_rest&type=code&p=1
Update Ansible collection requirements to include cisco.nd
https://github.com/netascode/ansible-dc-vxlan-example/blob/main/requirements.yaml
Verify end to end workflows using the nd connection plugin
https://github.com/netascode/ansible-dc-vxlan-example/blob/main/requirements.yaml
Replace this line with ansible_network_os: cisco.nd.nd

Test Notes

Tested with the below playbook

  • hosts: nac-fabric1
    any_errors_fatal: true
    gather_facts: no

    tasks:

    • name: Test simple GET request using nd_rest module
      cisco.nd.nd_rest:
      #path: "/api/v1/manage/fabricsSummary"
      #path: "/api/v1/manage/inventory/switches"
      #path: "/appcenter/cisco/ndfc/api/v1/lan-discovery/inventory/modules"
      path: "/appcenter/cisco/ndfc/api/v1/lan-fabric/rest/control/fabrics/"
      method: GET
      register: result

Cisco NDFC Version

Nexus Dashboard
Version 4.1.0.156b

Checklist

  • Latest commit is rebased from develop with merge conflicts resolved
  • New or updates to documentation has been made accordingly
  • Assigned the proper reviewers

@sivakasi-cisco
sivakasi-cisco requested a review from a team as a code owner July 24, 2025 11:02
@sivakasi-cisco

sivakasi-cisco commented Jul 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Author

https://github.com/CiscoDevNet/ansible-dcnm/issues/475

@sivakasi-cisco sivakasi-cisco mentioned this pull request Jul 24, 2025
Open
@mikewiebe

mikewiebe commented Jul 29, 2025

Copy link
Copy Markdown
Collaborator

Thanks @sivakasi-cisco for opening this PR. There are some conflicts that need to be resolved. You will likely need to merge latest develop branch into your feature branch

mikewiebe
mikewiebe reviewed Jul 29, 2025
View reviewed changes
Comment thread README.md Outdated
mikewiebe
mikewiebe reviewed Jul 29, 2025
View reviewed changes
Comment thread plugins/action/dtc/fabric_check_sync.py Outdated
sivakasi-cisco
sivakasi-cisco commented Aug 5, 2025
View reviewed changes
Comment thread plugins/action/dtc/fabric_check_sync.py
sivakasi-cisco
sivakasi-cisco commented Aug 5, 2025
View reviewed changes
Comment thread plugins/action/dtc/fabrics_config_save.py
sivakasi-cisco
sivakasi-cisco commented Aug 5, 2025
View reviewed changes
Comment thread plugins/action/dtc/fabrics_deploy.py
sivakasi-cisco
sivakasi-cisco commented Aug 5, 2025
View reviewed changes
Comment thread plugins/action/dtc/prepare_msite_data.py
sivakasi-cisco
sivakasi-cisco commented Aug 5, 2025
View reviewed changes
Comment thread plugins/plugin_utils/helper_functions.py
sivakasi-cisco
sivakasi-cisco commented Aug 5, 2025
View reviewed changes
Comment thread plugins/plugin_utils/helper_functions.py
sivakasi-cisco
sivakasi-cisco commented Aug 5, 2025
View reviewed changes
Comment thread roles/dtc/connectivity_check/tasks/main.yml Outdated
sivakasi-cisco
sivakasi-cisco commented Aug 6, 2025
View reviewed changes
Comment thread roles/dtc/create/tasks/external/fabric.yml Outdated
sivakasi-cisco
sivakasi-cisco commented Aug 6, 2025
View reviewed changes
Comment thread roles/dtc/create/tasks/common/devices_discovery.yml Outdated
mikewiebe
mikewiebe reviewed Aug 6, 2025
View reviewed changes
Comment thread roles/dtc/connectivity_check/tasks/main.yml Outdated
sivakasi-cisco
sivakasi-cisco commented Aug 13, 2025
View reviewed changes
Comment thread roles/dtc/connectivity_check/tasks/main.yml
sivakasi-cisco
sivakasi-cisco commented Aug 18, 2025
View reviewed changes
Comment thread roles/dtc/remove/tasks/vxlan/vrfs.yml
sivakasi-cisco
sivakasi-cisco commented Aug 18, 2025
View reviewed changes
Comment thread roles/dtc/remove/tasks/vxlan/networks.yml
sivakasi-cisco
sivakasi-cisco commented Aug 18, 2025
View reviewed changes
Comment thread roles/dtc/create/tasks/common/devices_discovery.yml
sivakasi-cisco
sivakasi-cisco commented Aug 18, 2025
View reviewed changes
Comment thread roles/dtc/create/tasks/external/devices_discovery.yml
sivakasi-cisco
sivakasi-cisco commented Aug 19, 2025
View reviewed changes
Comment thread plugins/action/dtc/rest_module_utils.py Outdated
@mikewiebe mikewiebe self-assigned this Aug 25, 2025
@mikewiebe mikewiebe added the ready for review PR Ready for Review label Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikewiebe mikewiebe mikewiebe left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@mikewiebe mikewiebe

Labels

ready for review PR Ready for Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sivakasi-cisco @mikewiebe