fixing indentation on ibgp spine and leaf templates

[juarocha]

Related Issue(s)

Fixes #758

Related Collection Role

• cisco.nac_dc_vxlan.validate
• cisco.nac_dc_vxlan.dtc.create
• cisco.nac_dc_vxlan.dtc.deploy
• cisco.nac_dc_vxlan.dtc.remove
• other

Related Data Model Element

• vxlan.fabric
• vxlan.global
• vxlan.topology
• vxlan.underlay
• vxlan.overlay
• vxlan.overlay_extensions
• vxlan.policy
• vxlan.multisite
• defaults.vxlan
• other

Proposed Changes

Fixing indentation on template, per error descripton:

iBGP peer template: bgp peer template command must have 2 leading spaces. Please fix spacing problem: template peer LEAVES. iBGP peer template: bgp peer template sub-command must have 4 or 6 leading spaces

Test Notes

Cisco Nexus Dashboard Version

4.1.1g

Checklist

• Latest commit is rebased from develop with merge conflicts resolved
• New or updates to documentation has been made accordingly
• Assigned the proper reviewers

[juarocha]

@mtarking, @mikewiebe, @ccoueffe I did some additional testing:

The string we grab from the data model needs to have 3 tabs (6 spaces) of indentation to be properly rendered. 2 initial spaces required by the base collection + to indicate that the string is a multi-line string + 2 required by ND (this templates are used under BGP config).

By default on the jinja2 filter indent(), the first line and blank lines are not indented (false is the default on the second parameter).

That's why we need the 6 spaces at the beginning of the line. An alternative will be to remove those spaces and set the flag as true, something like:

  IBGP2_PEER_TEMPLATE_LEAF: |2
{{ vxlan.global.ibgp.leaf_ibgp_peer_template_freeform2 | default("") | indent(6, true) }}

[juburnet]

@ccoueffe if you can re-review

[ccoueffe]

LGTM