feat: allow loose matching on primary values after checking for unique#108
Open
ltucker wants to merge 5 commits into
Open
feat: allow loose matching on primary values after checking for unique#108ltucker wants to merge 5 commits into
ltucker wants to merge 5 commits into
Conversation
…rough an exception Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Contributor
Author
|
this is missing a test of the ambiguity error I believe |
leoparente
approved these changes
May 21, 2025
jajeffries
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates diodes matching procedure to consider looser matches when no unique match can be found. This attempts a match on the "primary value" for the type when known (often "name" but not always).
Some caveats:
This can potentially have unintended consequences (though these are in some respect the requested/desired types of actions)
if a "scoped" object (eg an object with an associated tenant, vrf etc) is specified and loosely matches and "unscoped" (eg global) object, the global object may be modified and become scoped rather than creating a new scoped object.
if an "unscoped" object is specified and a scoped object loosely matches the scoped object may be modified instead of creating a new global object.