Preserve executable modes for skill resources#103
Merged
Aaronontheweb merged 5 commits intoJul 3, 2026
Merged
Conversation
This was referenced Jul 2, 2026
Aaronontheweb
commented
Jul 2, 2026
Aaronontheweb
left a comment
Aaronontheweb
left a comment
Contributor
Author
There was a problem hiding this comment.
Generally LGTM
| public string Url { get; init; } = ""; | ||
|
|
||
| [JsonPropertyName("unixMode")] | ||
| public int? UnixMode { get; init; } |
Contributor
Author
There was a problem hiding this comment.
Have to preserve the unix mode on uploaded files if we're including executable resources
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #102.
Summary
This PR preserves executable permission bits for skill resources uploaded through skill-server so archive consumers can run packaged helpers without manual chmod.
Changes
skill_files.unix_modemigrationresourceMetadatawith optionalunixModefor multipart resource uploadsunixModein RFC resource entriesSkillResourceUploadAPIsValidation
dotnet build SkillServer.slnxdotnet test SkillServer.slnxRelated