Skip to content

Commit 01ede18

Browse files
committed
Fix scanner findings: dead code and secrets false positive
Remove the unused sendRejection helper left behind by the Go transport deduplication (staticcheck U1000, failing the Static Analysis workflow). Truncate a full 40-hex commit SHA in SOW-0015 to its short form: written next to the word SonarCloud it pattern-matched the Semgrep detected-sonarqube-docs-api-key secrets rule, failing every Codacy Local Analysis run since June 8 and raising two false-positive code scanning alerts.
1 parent f91393f commit 01ede18

2 files changed

Lines changed: 2 additions & 5 deletions

File tree

.agents/sow/current/SOW-0015-20260605-codacy-scope-and-maintainability.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -908,7 +908,8 @@ Validation for this increment:
908908

909909
Fresh Netdata PR #22649 SonarCloud evidence after vendoring plugin-ipc commit `f5eca1e`:
910910

911-
- SonarCloud analyzed Netdata PR head `08fcd6594fec0f5f3fa323946e35cf7354f0fe0f`.
911+
- SonarCloud analyzed Netdata PR head `08fcd6594fec` (short SHA; the full hash
912+
trips secret scanners when written next to the word SonarCloud).
912913
- SonarCloud new-code duplication improved from 1024 lines / 5.903378300472731% to:
913914
- new duplicated lines: 666.
914915
- new duplicated blocks: 33.

src/go/pkg/netipc/transport/posix/uds_handshake.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -138,10 +138,6 @@ func serverHandshake(fd int, config *ServerConfig, sessionID uint64) (*Session,
138138
}, nil
139139
}
140140

141-
func sendRejection(fd int, status uint16) {
142-
_ = sendHelloAck(fd, status, protocol.HelloAck{LayoutVersion: 1})
143-
}
144-
145141
func sendHelloAck(fd int, status uint16, ack protocol.HelloAck) error {
146142
pkt := framing.BuildHelloAckPacket(status, ack)
147143

0 commit comments

Comments
 (0)