Merge pull request #94 from netgen/NGSTACK-672-remove-remoteid-urlencode

NGSTACK-672 Remove urlencode for IDs when fetching remote resource

Author: iherak

.github/workflows/tests.yml

@@ -34,8 +34,12 @@ jobs:
 
       # Install Flex as a global dependency to enable usage of extra.symfony.require
       # while keeping Flex recipes from applying
+      - run: composer global config --no-plugins allow-plugins.symfony/flex true
       - run: composer global require --no-scripts symfony/flex
 
+      # Install eZ Publish legacy installer as a global dependency
+      - run: composer config --no-plugins allow-plugins.ezsystems/ezpublish-legacy-installer true
+
       - run: composer config extra.symfony.require ${{ matrix.symfony }}
 
       -

bundle/Converter/XmlText/NgRemoteMediaPreConverter.php

@@ -8,7 +8,6 @@
 use DOMXPath;
 use eZ\Publish\Core\FieldType\XmlText\Converter;
 use Netgen\Bundle\RemoteMediaBundle\RemoteMedia\RemoteMediaProvider;
-use function basename;
 use function json_decode;
 
 class NgRemoteMediaPreConverter implements Converter

bundle/RemoteMedia/Provider/Cloudinary/CloudinaryProvider.php

@@ -286,8 +286,7 @@ public function getVideoThumbnail(Value $value, $options = []): string
     {
         if (array_key_exists('content_type_identifier', $options) && array_key_exists('variation_name', $options)) {
             $options['transformation'] = $this->processConfiguredVariation($value, $options['variation_name'], $options['content_type_identifier']);
-            unset($options['content_type_identifier']);
-            unset($options['variation_name']);
+            unset($options['content_type_identifier'], $options['variation_name']);
         }
 
         if (count($options) === 0 || !array_key_exists('resource_type', $options)) {

bundle/RemoteMedia/Provider/Cloudinary/Gateway/CloudinaryApiGateway.php

@@ -28,7 +28,6 @@
 use function min;
 use function round;
 use function sprintf;
-use function urlencode;
 
 class CloudinaryApiGateway extends Gateway
 {
@@ -264,12 +263,6 @@ public function countResourcesInFolder($folder)
     public function get($id, $type)
     {
         try {
-            $id = array_map(function (string $part) {
-                return urlencode($part);
-            }, explode('/', $id));
-
-            $id = implode('/', $id);
-
             return (array) $this->cloudinaryApi->resource($id, ['resource_type' => $type]);
         } catch (Cloudinary\Error $e) {
             return [];