Update PHPStan

Author: emodric

phpstan.neon

@@ -29,7 +29,6 @@ parameters:
         - '#Call to function is_string\(\) with string will always evaluate to true.#'
         - '#Call to function is_array\(\) with array(<.*>)? will always evaluate to true.#'
         - '#Instanceof between (.*) and (.*) will always evaluate to true.#'
-        - "#Casting to int something that's already int.#"
         - '#should be contravariant with parameter#'
         - '#should be covariant with return type#'
         - "#Casting to bool something that's already bool.#"

phpstan.tests.neon

@@ -8,3 +8,4 @@ parameters:
         - identifier: missingType.iterableValue
         - '#Access to an undefined property Netgen\\TagsBundle\\API\\Repository\\Values\\Tags\\Tag::\$notDefined.#'
         - '#Missing call to parent::setUp\(\) method.#'
+        - "#Call to static method PHPUnit\\\\Framework\\\\Assert::assertSame\\(\\) with 'some_value' and 'some_value' will always evaluate to true.#"

tests/Core/Event/TagsServiceTest.php

@@ -756,12 +756,12 @@ public function testNewTagUpdateStruct(): void
      */
     public function testSudo(): void
     {
-        $callback = static function (): void {};
+        $callback = static function (): string { return 'some_value'; };
 
         $this->tagsService
             ->expects(self::once())
             ->method('sudo')
-            ->willReturn('some_value');
+            ->willReturn($callback());
 
         $eventDispatchingService = $this->getEventDispatchingService();
         $value = $eventDispatchingService->sudo($callback);