Ngstack 1017 extending refresh token#6
Merged
Conversation
emodric
reviewed
Feb 26, 2026
| public static function createForUserWithTtl(string $refreshToken, UserInterface $user, int $ttl): static | ||
| { | ||
| return parent::createForUserWithTtl($refreshToken, $user, $ttl) | ||
| ->setClass($user::class); |
Member
There was a problem hiding this comment.
We should probably add the gesdinet bundle to dependencies (at least require-dev and suggests).
Contributor
Author
There was a problem hiding this comment.
Its under required, should it be moved to require-dev? Whole refresh feature relies heavy on its existence.
Member
There was a problem hiding this comment.
No, it's okay, i presumed it's missing since PHPStan complained.
As for require-dev, I don't know really. It makes sense for it to go to require-dev as the feature is not required 100%, so you throw an exception if you enable the feature and the bundle is not installed and enabled.
But the way it is now is okay enough for now.
emodric
approved these changes
Feb 26, 2026
Member
|
Thanks @JakovKnezovicc ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
• Adds user-aware JWT refresh support and fixes refresh token mapping integration.