Fix PHPStan issues

Author: emodric

bundle/Command/BaseMultiprocessCommand.php

@@ -221,7 +221,6 @@ protected function dispatch(int $processCount, int $limit): void
     {
         $generator = $this->internalGetItemGenerator($limit);
 
-        /** @var \Symfony\Component\Process\Process[]|null[] $processes */
         $processes = array_fill(0, $processCount, null);
         $processDepthMap = [];
         $itemList = null;

bundle/Command/DumpDatabaseCommand.php

@@ -50,6 +50,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
             $fs->mkdir($targetDirectory);
         }
 
+        /** @var array{ user: string, host: string, dbname: string, password: string } $params */
         $params = $this->connection->getParams();
 
         // https://dev.mysql.com/doc/refman/5.7/en/mysqldump.html#option_mysqldump_opt

bundle/Command/GenerateImageVariationsCommand.php

@@ -89,7 +89,7 @@ function (Repository $repository) use ($query): int {
         $fields = $this->parseCommaDelimited($input->getOption('fields'));
 
         do {
-            /** @var \Ibexa\Contracts\Core\Repository\Values\Content\Search\SearchHit[] $searchHits */
+            /** @var \Ibexa\Contracts\Core\Repository\Values\Content\Search\SearchHit<\Ibexa\Contracts\Core\Repository\Values\Content\Content>[] $searchHits */
             $searchHits = $this->repository->sudo(
                 function (Repository $repository) use ($query): iterable {
                     $languages = $this->configResolver->getParameter('languages');
@@ -98,7 +98,6 @@ function (Repository $repository) use ($query): iterable {
                 },
             );
 
-            /** @var \Ibexa\Contracts\Core\Repository\Values\Content\Content[] $contentItems */
             $contentItems = array_map(
                 static fn (SearchHit $searchHit): ValueObject => $searchHit->valueObject,
                 $searchHits,
@@ -132,7 +131,7 @@ private function clearVariationCache(Content $content): void
     private function generateVariations(Content $content, array $variations, array $fields): void
     {
         foreach ($content->getFields() as $field) {
-            if ($field->fieldTypeIdentifier !== 'ezimage') {
+            if ($field->fieldTypeIdentifier !== 'ibexa_image') {
                 continue;
             }
 
@@ -201,6 +200,15 @@ private function parseCommaDelimited(?string $value): array
             return [];
         }
 
-        return array_values(array_unique(array_filter(array_map('trim', explode(',', $value)))));
+        $values = array_map('mb_trim', explode(',', $value));
+
+        return array_values(
+            array_unique(
+                array_filter(
+                    $values,
+                    static fn (string $value): bool => $value !== '',
+                )
+            )
+        );
     }
 }

bundle/Command/GenerateShowcaseCommand.php

@@ -523,7 +523,7 @@ private function findParameterDefinition(
         }
 
         foreach ($parameterDefinitionCollection->parameterDefinitions as $innerParameterDefinition) {
-            if (!$innerParameterDefinition instanceof ParameterDefinitionCollectionInterface) {
+            if (!$innerParameterDefinition->isCompound) {
                 continue;
             }
 

bundle/Command/MoveContentTypeCommand.php

@@ -22,8 +22,6 @@
 
 final class MoveContentTypeCommand extends Command
 {
-    protected static $defaultDescription = 'Assigns content type(s) to a single content type group';
-
     private SymfonyStyle $style;
 
     public function __construct(
@@ -37,6 +35,7 @@ public function __construct(
     protected function configure(): void
     {
         $this
+            ->setDescription('Assigns content type(s) to a single content type group')
             ->addArgument(
                 'types',
                 InputArgument::REQUIRED,
@@ -65,7 +64,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         }
 
         $types = $input->getArgument('types');
-        $contentTypeIdentifiersOrIds = array_map('trim', explode(',', $types));
+        $contentTypeIdentifiersOrIds = array_map('mb_trim', explode(',', $types));
         $contentTypeGroupIdentifierOrId = (string) $input->getArgument('group');
 
         $newContentTypeGroup = $this->loadContentTypeGroup($contentTypeGroupIdentifierOrId);

bundle/Command/TagContentByTypesCommand.php

@@ -177,6 +177,15 @@ private function parseCommaDelimited(string $value): array
             return [];
         }
 
-        return array_values(array_unique(array_filter(array_map('trim', explode(',', $value)))));
+        $values = array_map('mb_trim', explode(',', $value));
+
+        return array_values(
+            array_unique(
+                array_filter(
+                    $values,
+                    static fn (string $value): bool => $value !== '',
+                )
+            )
+        );
     }
 }

bundle/Command/UpdateContentAlwaysAvailableCommand.php

@@ -17,8 +17,6 @@
 
 final class UpdateContentAlwaysAvailableCommand extends Command
 {
-    protected static $defaultDescription = 'Update always-available state for the given Content item(s)';
-
     private SymfonyStyle $style;
 
     public function __construct(
@@ -31,6 +29,7 @@ public function __construct(
     protected function configure(): void
     {
         $this
+            ->setDescription('Update always-available state for the given Content item(s)')
             ->addArgument(
                 'content-ids',
                 InputArgument::REQUIRED,
@@ -60,7 +59,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         }
 
         $types = $input->getArgument('content-ids');
-        $contentIds = array_map('intval', array_map('trim', explode(',', $types)));
+        $contentIds = array_map('intval', array_map('mb_trim', explode(',', $types)));
         $alwaysAvailableState = $this->resolveAlwaysAvailableState($input->getArgument('always-available'));
 
         foreach ($contentIds as $contentId) {

bundle/ContentForms/FieldType/Mapper/BinaryFileFormMapper.php

@@ -23,7 +23,7 @@ public function __construct(
 
     public function mapFieldValueForm(FormInterface $fieldForm, FieldData $data): void
     {
-        $fieldDefinition = $data->fieldDefinition;
+        $fieldDefinition = $data->getFieldDefinition();
         $formConfig = $fieldForm->getConfig();
         $fieldType = $this->fieldTypeService->getFieldType($fieldDefinition->fieldTypeIdentifier);
         $value = $data->value ?? $fieldType->getEmptyValue();

bundle/Controller/Download.php

@@ -85,7 +85,7 @@ public function __invoke(Request $request, int|string $contentId, int|string $fi
 
         if ($binaryFieldValue instanceof BinaryBaseValue) {
             $ioService = $this->ioFileService;
-            $binaryFile = $this->ioFileService->loadBinaryFile($binaryFieldValue->id);
+            $binaryFile = $this->ioFileService->loadBinaryFile((string) $binaryFieldValue->id);
         } elseif ($binaryFieldValue instanceof ImageValue) {
             $ioService = $this->ioImageService;
             $binaryFile = $this->ioImageService->loadBinaryFile($binaryFieldValue->id);

bundle/Core/EventListener/CreateUserListener.php

@@ -21,8 +21,8 @@ public static function getSubscribedEvents(): array
 
     public function onCreateUser(CreateUserEvent $event): void
     {
-        if ($event->user->enabled) {
-            $this->ngUserSettingRepository->activateUser($event->user->id);
+        if ($event->getUser()->enabled) {
+            $this->ngUserSettingRepository->activateUser($event->getUser()->id);
         }
     }
 }