Switch events to use asymetric visibility

Author: emodric

bundle/Controller/User/Activate.php

@@ -64,7 +64,7 @@ public function __invoke(string $hash): Response
 
         $preActivateEvent = new UserEvents\PreActivateEvent($user, $userUpdateStruct);
         $this->eventDispatcher->dispatch($preActivateEvent, SiteEvents::USER_PRE_ACTIVATE);
-        $userUpdateStruct = $preActivateEvent->getUserUpdateStruct();
+        $userUpdateStruct = $preActivateEvent->userUpdateStruct;
 
         $user = $this->repository->sudo(
             static fn (Repository $repository): User => $repository->getUserService()->updateUser($user, $userUpdateStruct),

bundle/Controller/User/Register.php

@@ -109,7 +109,7 @@ public function __invoke(Request $request): Response
         $preUserRegisterEvent->setParameter('form', $form);
 
         $this->eventDispatcher->dispatch($preUserRegisterEvent, SiteEvents::USER_PRE_REGISTER);
-        $data->payload = $preUserRegisterEvent->getUserCreateStruct();
+        $data->payload = $preUserRegisterEvent->userCreateStruct;
 
         foreach ($data->payload->fields as $field) {
             if ($field->fieldTypeIdentifier !== 'ibexa_user') {

bundle/Controller/User/ResetPassword.php

@@ -85,7 +85,7 @@ public function __invoke(Request $request, string $hash): Response
         $prePasswordResetEvent->setParameter('form', $form);
 
         $this->eventDispatcher->dispatch($prePasswordResetEvent, SiteEvents::USER_PRE_PASSWORD_RESET);
-        $userUpdateStruct = $prePasswordResetEvent->getUserUpdateStruct();
+        $userUpdateStruct = $prePasswordResetEvent->userUpdateStruct;
 
         $user = $this->repository->sudo(
             static fn (Repository $repository): User => $repository->getUserService()->updateUser($user, $userUpdateStruct),

bundle/Core/EventListener/CreateUserListener.php

@@ -21,10 +21,8 @@ public static function getSubscribedEvents(): array
 
     public function onCreateUser(CreateUserEvent $event): void
     {
-        $user = $event->getUser();
-
-        if ($user->enabled) {
-            $this->ngUserSettingRepository->activateUser($user->id);
+        if ($event->user->enabled) {
+            $this->ngUserSettingRepository->activateUser($event->user->id);
         }
     }
 }

bundle/Event/Content/DownloadEvent.php

@@ -10,41 +10,9 @@
 final class DownloadEvent extends Event
 {
     public function __construct(
-        private int $contentId,
-        private int $fieldId,
-        private int $versionNo,
-        private BinaryStreamResponse $response,
+        public private(set) int $contentId,
+        public private(set) int $fieldId,
+        public private(set) int $versionNo,
+        public private(set) BinaryStreamResponse $response,
     ) {}
-
-    /**
-     * Get field ID.
-     */
-    public function getFieldId(): int
-    {
-        return $this->fieldId;
-    }
-
-    /**
-     * Returns content ID.
-     */
-    public function getContentId(): int
-    {
-        return $this->contentId;
-    }
-
-    /**
-     * Returns version number.
-     */
-    public function getVersionNo(): int
-    {
-        return $this->versionNo;
-    }
-
-    /**
-     * Returns the response.
-     */
-    public function getResponse(): BinaryStreamResponse
-    {
-        return $this->response;
-    }
 }

bundle/Event/Menu/LocationMenuItemEvent.php

@@ -14,23 +14,13 @@
 final class LocationMenuItemEvent extends Event
 {
     public function __construct(
-        private ItemInterface $item,
-        private Location $location,
+        /**
+         * Returns the item which was built.
+         */
+        public private(set) ItemInterface $item,
+        /**
+         * Returns the Ibexa location for which the menu item was built.
+         */
+        public private(set) Location $location,
     ) {}
-
-    /**
-     * Returns the item which was built.
-     */
-    public function getItem(): ItemInterface
-    {
-        return $this->item;
-    }
-
-    /**
-     * Returns the Ibexa location for which the menu item was built.
-     */
-    public function getLocation(): Location
-    {
-        return $this->location;
-    }
 }

bundle/Event/User/ActivationRequestEvent.php

@@ -9,17 +9,7 @@
 final class ActivationRequestEvent extends UserEvent
 {
     public function __construct(
-        private string $email,
-        private ?User $user = null,
+        public private(set) string $email,
+        public private(set) ?User $user = null,
     ) {}
-
-    public function getEmail(): string
-    {
-        return $this->email;
-    }
-
-    public function getUser(): ?User
-    {
-        return $this->user;
-    }
 }

bundle/Event/User/PasswordResetRequestEvent.php

@@ -9,17 +9,7 @@
 final class PasswordResetRequestEvent extends UserEvent
 {
     public function __construct(
-        private string $email,
-        private ?User $user = null,
+        public private(set) string $email,
+        public private(set) ?User $user = null,
     ) {}
-
-    public function getEmail(): string
-    {
-        return $this->email;
-    }
-
-    public function getUser(): ?User
-    {
-        return $this->user;
-    }
 }

bundle/Event/User/PostActivateEvent.php

@@ -9,11 +9,6 @@
 final class PostActivateEvent extends UserEvent
 {
     public function __construct(
-        private User $user,
+        public private(set) User $user,
     ) {}
-
-    public function getUser(): User
-    {
-        return $this->user;
-    }
 }

bundle/Event/User/PostPasswordResetEvent.php

@@ -9,11 +9,6 @@
 final class PostPasswordResetEvent extends UserEvent
 {
     public function __construct(
-        private User $user,
+        public private(set) User $user,
     ) {}
-
-    public function getUser(): User
-    {
-        return $this->user;
-    }
 }