[NAE-2169] User flag for internal or external

- code cleanup

Author: SamuelPalaj

application-engine/src/main/java/com/netgrif/application/engine/auth/service/RegistrationService.java

@@ -117,7 +117,8 @@ public void encodeUserPassword(User user) {
 
     @Override
     public boolean stringMatchesUserPassword(User user, String passwordToCompare) {
-        return passwordEncoder.matches(passwordToCompare, user.getPassword());
+        String encoded = user.getPassword();
+        return encoded != null && passwordEncoder.matches(passwordToCompare, encoded);
     }
 
     @Override

application-engine/src/main/java/com/netgrif/application/engine/impersonation/service/ImpersonationService.java

@@ -153,7 +153,7 @@ public User reloadImpersonatedUserRoles(User impersonated, String impersonatorId
 
     @Override
     public User applyRolesAndAuthorities(User impersonated, String impersonatorId, List<Case> configs) {
-        if ((Boolean) userService.findById(impersonatorId, null).getAuthoritySet().contains(new AuthorityImpl(Authority.admin))) {
+        if (userService.findById(impersonatorId, null).isAdmin()) {
             return impersonated;
         }
         List<Authority> authorities = impersonationAuthorizationService.getAuthorities(configs, impersonated);

application-engine/src/main/java/com/netgrif/application/engine/startup/runner/SuperCreatorRunner.java

@@ -46,7 +46,7 @@ public void run(ApplicationArguments strings) {
         createSuperUser();
     }
 
-    private AbstractUser createSuperUser() {
+    private User createSuperUser() {
         Authority adminAuthority = authorityService.getOrCreate(Authority.admin);
         Authority systemAuthority = authorityService.getOrCreate(Authority.systemAdmin);
         Set<Authority> authorities = new HashSet<>();

nae-user-common/src/main/java/com/netgrif/application/engine/auth/service/GroupService.java

@@ -1,18 +1,17 @@
 package com.netgrif.application.engine.auth.service;
 
-import com.netgrif.application.engine.objects.auth.domain.AbstractUser;
 import com.netgrif.application.engine.objects.auth.domain.Group;
 import com.netgrif.application.engine.objects.auth.domain.User;
 import com.netgrif.application.engine.objects.auth.dto.GroupSearchDto;
-import org.springframework.data.mongodb.core.query.Query;
 import com.querydsl.core.types.Predicate;
 import org.springframework.data.domain.Page;
 import org.springframework.data.domain.Pageable;
+import org.springframework.data.mongodb.core.query.Query;
 import org.springframework.data.util.Pair;
 
 import java.util.Collection;
-import java.util.Optional;
 import java.util.List;
+import java.util.Optional;
 
 /**
  * Service interface for managing user groups in the application.