Fix proto files installation#62
Draft
cscarpitta wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will fix an issue of protos not installed correctly in systems where several python interpreters are installed.
This project depends on some python classes generated from proto files. Building the proto files requires the grpcio-tools python library to be installed in your system.
We automated all these steps in the control_plane/protos/setup.py: in the current release of the project, the setup scripts first installs the grpcio-tools library by using pip and then it builds the proto files.
By running a pip install from inside a Python script, we are not able to specify the interpreter for which the package is installed.
For example, if you have both Python3.6 and Python2.7 in your system and you run
python3.6 setup.py, it is possible that the grpcio-tools library is installed for Python2.7, and this causes a failure in the build process of the proto files.This PR will fix this issue: the setup.py of the protos has been re-implemented following the design proposed in the official grpcio-tools doc: https://github.com/grpc/grpc/tree/master/tools/distrib/python/grpcio_tools
Basically, the pip installation has been replaced by the a setup_requires directive and the proto compilation has been implemented as described in the doc.