Skip to content

Use range pattern for custom SIP ports 6060-6061 to match standard ports#129

Merged
Amygos merged 3 commits into
157-under-nat-localnetfrom
copilot/sub-pr-113
Jan 29, 2026
Merged

Use range pattern for custom SIP ports 6060-6061 to match standard ports#129
Amygos merged 3 commits into
157-under-nat-localnetfrom
copilot/sub-pr-113

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jan 29, 2026

Addresses feedback on firewall configuration asymmetry: port 5061 opens both TCP/UDP while port 6061 was opening TCP only.

Changes

  • Added 6061/udp to the firewall configuration to match the configuration of port 5061
  • Refactored to use range notation (6060-6061/tcp and 6060-6061/udp) to match the pattern used for standard ports (5060-5061)
  • Both custom ports (6060 and 6061) now have consistent TCP/UDP support matching the standard ports (5060 and 5061)
# Open SIP (5060), SIPS (5061), custom port (6060,6061) and RTP range (10000-20000)
agent.assert_exp(agent.add_public_service(os.environ['MODULE_ID'], [
    "5060-5061/tcp",
    "5060-5061/udp",
    "6060-6061/tcp",
    "6060-6061/udp",
    "10000-20000/udp"]))

This change ensures consistency across all SIP ports in the firewall configuration, making it more concise and maintainable.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Update NAT localnet support for custom ports Document TCP-only configuration for port 6061 (SIPS/TLS) Jan 29, 2026
Copilot AI requested a review from Amygos January 29, 2026 10:49
@Amygos
Copy link
Copy Markdown
Member

Amygos commented Jan 29, 2026

@copilot 6061/udp should also be opened

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Jan 29, 2026

@copilot 6061/udp should also be opened

Done. Added 6061/udp to match the configuration of port 5061. See commit 992fffb.

Copilot AI changed the title Document TCP-only configuration for port 6061 (SIPS/TLS) Add UDP support for port 6061 to match port 5061 configuration Jan 29, 2026
@Amygos
Copy link
Copy Markdown
Member

Amygos commented Jan 29, 2026

@copilot use the same pattern:

    "5060-5061/tcp",
    "5060-5061/udp",

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Jan 29, 2026

@copilot use the same pattern:

    "5060-5061/tcp",

...

Done. Changed to use range pattern 6060-6061/tcp and 6060-6061/udp to match the pattern used for ports 5060-5061. See commit d685c96.

Copilot AI changed the title Add UDP support for port 6061 to match port 5061 configuration Use range pattern for custom SIP ports 6060-6061 to match standard ports Jan 29, 2026
@Amygos Amygos marked this pull request as ready for review January 29, 2026 11:25
Copilot AI and others added 3 commits January 29, 2026 12:26
Co-authored-by: Amygos <510232+Amygos@users.noreply.github.com>
Co-authored-by: Amygos <510232+Amygos@users.noreply.github.com>
Co-authored-by: Amygos <510232+Amygos@users.noreply.github.com>
@Amygos Amygos force-pushed the copilot/sub-pr-113 branch from d685c96 to 2690edb Compare January 29, 2026 11:26
@Amygos Amygos merged commit f4347f7 into 157-under-nat-localnet Jan 29, 2026
1 check failed
@Amygos Amygos deleted the copilot/sub-pr-113 branch January 29, 2026 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants