Skip to content

Fix missing sys import in destroy-module firewall script#131

Merged
Amygos merged 3 commits into
157-under-nat-localnetfrom
copilot/sub-pr-113
Jan 29, 2026
Merged

Fix missing sys import in destroy-module firewall script#131
Amygos merged 3 commits into
157-under-nat-localnetfrom
copilot/sub-pr-113

Conversation

Copilot AI commented Jan 29, 2026

Copy link
Copy Markdown
Contributor

The destroy-module/20firewall script references sys.stderr without importing the sys module, causing a NameError at runtime when firewall rule removal fails.

Changes

  • Added import sys to imageroot/actions/destroy-module/20firewall
import os
import sys  # Added - required for sys.stderr usage on line 38
import agent

The script writes warnings to stderr when rich rule removal fails, but the import was missing from the initial implementation.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: Amygos <510232+Amygos@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix NAT localnet support with custom ports based on feedback Add missing sys import to destroy-module firewall script Jan 29, 2026
Copilot AI requested a review from Amygos January 29, 2026 11:36
Co-authored-by: Amygos <510232+Amygos@users.noreply.github.com>
Copilot AI changed the title Add missing sys import to destroy-module firewall script Fix missing sys import in destroy-module firewall script Jan 29, 2026
@Amygos
Amygos marked this pull request as ready for review January 29, 2026 11:40
@Amygos
Amygos merged commit 63000da into 157-under-nat-localnet Jan 29, 2026
@Amygos
Amygos deleted the copilot/sub-pr-113 branch January 29, 2026 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants