Fix missing sys import in destroy-module firewall script#131
Merged
Conversation
Co-authored-by: Amygos <510232+Amygos@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix NAT localnet support with custom ports based on feedback
Add missing sys import to destroy-module firewall script
Jan 29, 2026
Co-authored-by: Amygos <510232+Amygos@users.noreply.github.com>
Copilot
AI
changed the title
Add missing sys import to destroy-module firewall script
Fix missing sys import in destroy-module firewall script
Jan 29, 2026
Amygos
marked this pull request as ready for review
January 29, 2026 11:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
destroy-module/20firewallscript referencessys.stderrwithout importing the sys module, causing a NameError at runtime when firewall rule removal fails.Changes
import systoimageroot/actions/destroy-module/20firewallThe script writes warnings to stderr when rich rule removal fails, but the import was missing from the initial implementation.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.