Skip to content

Fix inaccurate comment describing socket configuration in kamailio.cfg#132

Merged
Amygos merged 3 commits into
157-under-nat-localnetfrom
copilot/sub-pr-113
Jan 29, 2026
Merged

Fix inaccurate comment describing socket configuration in kamailio.cfg#132
Amygos merged 3 commits into
157-under-nat-localnetfrom
copilot/sub-pr-113

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jan 29, 2026

Addresses review feedback on PR #113 regarding a misleading comment in the SET_SOCKET route documentation.

Changes

  • LOCALNETWORKS comment: Changed from "uses PRIVATE_IP for advertised address" to "sets the socket to PRIVATE_IP:6060 (specific IP:port)" to accurately reflect $fs = PRIVATE_IP + ":6060";
  • INTERNAL_NETWORK comment: Updated to include port number ("SERVICE_IP:5060") for consistency with the actual implementation $fs = SERVICE_IP + ":5060";

Both comments now accurately describe the socket assignment behavior rather than suggesting advertised address usage.

# Before
# - LOCALNETWORKS: uses PRIVATE_IP for advertised address
# - INTERNAL_NETWORK: forces socket to SERVICE_IP for traffic to Asterisk

# After  
# - LOCALNETWORKS: sets the socket to PRIVATE_IP:6060 (specific IP:port)
# - INTERNAL_NETWORK: forces socket to SERVICE_IP:5060 (specific IP:port) for traffic to Asterisk

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits January 29, 2026 14:04
Co-authored-by: Amygos <510232+Amygos@users.noreply.github.com>
Co-authored-by: Amygos <510232+Amygos@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback on NAT localnet support with custom ports Fix inaccurate comment describing socket configuration in kamailio.cfg Jan 29, 2026
Copilot AI requested a review from Amygos January 29, 2026 14:07
@Amygos Amygos marked this pull request as ready for review January 29, 2026 14:08
@Amygos Amygos merged commit 0019e79 into 157-under-nat-localnet Jan 29, 2026
@Amygos Amygos deleted the copilot/sub-pr-113 branch January 29, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants