Skip to content

feat: 🎉 Adding TidyDNS provider#1

Merged
langecode merged 6 commits into
mainfrom
feature/setup-fork
Nov 13, 2025
Merged

feat: 🎉 Adding TidyDNS provider#1
langecode merged 6 commits into
mainfrom
feature/setup-fork

Conversation

@langecode
Copy link
Copy Markdown
Member

What does it do ?

Motivation

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

Signed-off-by: Thor Anker Kvisgård Lange <tal@netic.dk>
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @langecode, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly extends the capabilities of external-dns by introducing support for TidyDNS as a new DNS provider. This integration allows users to leverage external-dns to automatically manage DNS records within their TidyDNS environment, configuring it via a new command-line flag for the service endpoint and environment variables for authentication. The changes encompass the full lifecycle of DNS record management (create, update, delete) for common record types, ensuring robust and tested functionality.

Highlights

  • TidyDNS Provider Integration: A new DNS provider, TidyDNS, has been added, enabling external-dns to manage DNS records via TidyDNS services.
  • Configuration Options: The "--tidydns-endpoint" flag is introduced for specifying the TidyDNS service endpoint, along with environment variable support for authentication credentials ("TIDYDNS_USER", "TIDYDNS_PASS").
  • Core Logic Implementation: The "tidydns" package includes the "TidyDNSProvider" implementation, handling record listing ("Records") and applying changes ("ApplyChanges") for A, CNAME, and TXT record types.
  • Dependency Management: The "go.mod" and "go.sum" files have been updated to include the "github.com/neticdk/tidydns-go" client library.
  • Documentation and Testing: The "docs/flags.md" file is updated to reflect the new provider and its configuration, and comprehensive unit tests are provided for the TidyDNS provider logic.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the TidyDNS provider, integrating it into ExternalDNS. The changes include adding the necessary Go module dependencies, updating configuration structures and flag bindings, and implementing the core provider logic along with its unit tests. The overall structure follows existing provider patterns within the project, which is good. However, there are a few areas that require attention to ensure correctness and robustness, particularly concerning the handling of TXT records and the update logic for existing records.

Comment thread provider/tidydns/tidydns.go
Comment thread provider/tidydns/tidydns.go
Comment thread provider/tidydns/tidydns.go
Comment thread provider/tidydns/tidydns.go Outdated
Comment thread provider/tidydns/tidydns.go
Comment thread provider/tidydns/tidydns.go
Comment thread provider/tidydns/tidydns.go Outdated
Comment thread provider/tidydns/tidydns.go Outdated
langecode and others added 5 commits November 11, 2025 20:16
Signed-off-by: Thor Anker Kvisgård Lange <tal@netic.dk>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Thor Anker Kvisgård Lange <tal@netic.dk>
Signed-off-by: Thor Anker Kvisgård Lange <tal@netic.dk>
Signed-off-by: Thor Anker Kvisgård Lange <tal@netic.dk>
@langecode langecode merged commit 10fdc38 into main Nov 13, 2025
3 checks passed
@langecode langecode deleted the feature/setup-fork branch November 13, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant