You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The default Node.js major version constant is updated from 22 to 24 in packages/zip-it-and-ship-it/src/runtimes/node/utils/node_version.ts. This constant serves as the fallback when getNodeVersion receives no config version. The esbuild bundler target mapping in packages/zip-it-and-ship-it/src/runtimes/node/bundlers/esbuild/bundler_target.ts is extended with a new entry to map Node version 24 to the string 'node24', enabling the bundler to target Node 24. Unit test expectations in node_runtime.test.ts are updated to reflect that inputs without explicit versions now resolve to nodejs24.x instead of nodejs22.x. Integration test cases in v2api.test.ts for older and invalid Node version scenarios are updated to expect the nodejs24.x fallback.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~8 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check name
Status
Explanation
Resolution
Description check
⚠️ Warning
The description is largely incomplete, missing the required 'Summary' section with issue reference and motivation. It only contains a note about coordination requirements and issue references.
Complete the description by adding a 'Summary' section that explains the motivation, fixes the referenced issue number, and follows the repository's PR template structure.
✅ Passed checks (4 passed)
Check name
Status
Explanation
Docstring Coverage
✅ Passed
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check
✅ Passed
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
✅ Passed
Check skipped because no linked issues were found for this pull request.
Title check
✅ Passed
The title clearly and accurately summarizes the main change: updating the default Node.js version to 24.
✨ Finishing Touches📝 Generate docstrings
Create stacked PR
Commit on current branch
🧪 Generate unit tests (beta)
Create PR with unit tests
Commit unit tests in branch hk/frb-2272
Comment @coderabbitai help to get the list of available commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge, needs a co-ordinated release
https://linear.app/netlify/issue/FRB-2272/ (follow-up of #5958)