fix: Dev server fixes (#8211)

🎉 Thanks for submitting a pull request! 🎉

#### Summary

* Remove listeners on failure to prevent leak
* Improve logging when running with`skipWaitPort`

```
  BEFORE
===========
  ⬥ Setting up local dev server
  ⬥ Starting #custom dev server
  ⠋ Waiting for #custom dev server to be ready on port 19876
  ✔ #custom dev server ready on port 19876                       ← misleading
     ╭──────────────────────── ⬥  ────────────────────────╮
     │   Local dev server ready: http://localhost:28888   │
     ╰────────────────────────────────────────────────────╯
  (node:67259) MaxListenersExceededWarning: ... 26 aborted listeners added to [IncomingMessage]
  (node:67259) MaxListenersExceededWarning: ... 26 error listeners added to [IncomingMessage]

  AFTER
============
  ⬥ Setting up local dev server
  ⬥ Starting #custom dev server
  ⠋ Waiting for #custom dev server to be ready on port 19876
     ╭──────────────────────── ⬥  ────────────────────────╮
     │   Local dev server ready: http://localhost:28888   │
     ╰────────────────────────────────────────────────────╯
```


---

For us to review and ship your PR efficiently, please perform the
following steps:

- [ ] Open a
[bug/issue](https://github.com/netlify/cli/issues/new/choose) before
writing your code 🧑‍💻. This ensures we can discuss the changes and get
feedback from everyone that should be involved. If you\`re fixing a typo
or something that\`s on fire 🔥 (e.g. incident related), you can skip
this step.
- [ ] Read the [contribution guidelines](../CONTRIBUTING.md) 📖. This
ensures your code follows our style guide and
      passes our tests.
- [ ] Update or add tests (if any source code was changed or added) 🧪
- [ ] Update or add documentation (if features were changed or added) 📝
- [ ] Make sure the status checks below are successful ✅

**A picture of a cute animal (not mandatory, but encouraged)**

Author: davbree

src/utils/framework-server.ts

@@ -54,6 +54,7 @@ export const startFrameworkServer = async function ({
       // default ip version based on node version
       const ipVersion = parseInt(process.versions.node.split('.')[0]) >= 18 ? 6 : 4
       port = { open: true, ipVersion }
+      stopSpinner({ spinner })
     } else {
       const waitPortPromise = waitPort(
         // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
@@ -81,8 +82,8 @@ export const startFrameworkServer = async function ({
       if (!port.open) {
         throw new Error(`Timed out waiting for port '${settings.frameworkPort}' to be open`)
       }
+      spinner.success(`${settings.framework || 'framework'} dev server ready on port ${settings.frameworkPort}`)
     }
-    spinner.success(`${settings.framework || 'framework'} dev server ready on port ${settings.frameworkPort}`)
   } catch (error_) {
     stopSpinner({ error: true, spinner })
     log(NETLIFYDEVERR, `Netlify Dev could not start or connect to localhost:${settings.frameworkPort}.`)

src/utils/proxy.ts

@@ -546,6 +546,10 @@ const initializeProxy = async function ({
         options.target = `http://${isIPv6(newHost) ? `[${newHost}]` : newHost}:${targetUrl.port}`
         options.targetHostname = newHost
         options.isChangingTarget = true
+        // http-proxy attaches new 'aborted'/'error' listeners on req for every proxy.web call; without
+        // clearing them first, retries leak listeners and the closures retain per-attempt proxyReq objects.
+        req.removeAllListeners('aborted')
+        req.removeAllListeners('error')
         proxy.web(req, res, options)
         return
       }
@@ -619,6 +623,10 @@ const initializeProxy = async function ({
       if (req.alternativePaths && req.alternativePaths.length !== 0) {
         // @ts-expect-error TS(2339) FIXME: Property 'alternativePaths' does not exist on type... Remove this comment to see the full error message
         req.url = req.alternativePaths.shift()
+        // http-proxy attaches new 'aborted'/'error' listeners on req for every proxy.web call; without
+        // clearing them first, retries leak listeners and the closures retain per-attempt proxyReq objects.
+        req.removeAllListeners('aborted')
+        req.removeAllListeners('error')
         // @ts-expect-error TS(2339) FIXME: Property 'proxyOptions' does not exist on type 'In... Remove this comment to see the full error message
         proxy.web(req, res, req.proxyOptions)
         return