Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This would need to happen in the other netlify packages too. It's clear that the duplicate packages increase by a lot... But assuming you guys really want to reduce your deps tree, this is a must change. Next, you'd need to start finding other places that deps need deduplication. v25.0.0 has ~100 duplicate packages. With this PR the number will increase, as it seems. Remember, updating deps blindly to the latest version, is not the right approach all the time, if one cares about the deps tree/count. Unless you can do it across all your dependencies, which isn't realistic... Just my 2 cents as a netlify-cli user who has reported the issue for years :) That is exactly the reason why I started contributing to dependents (precinct dependency, etc) packages in the first place. |
We were pinning deps to partially mimic the published npm-shrinkwrap.json for package managers like yarn and pnpm that don't support it. Since we stopped shipping the shrinkwrap in #8163, the pinning is no longer relevant. This will help users' dependency trees get heavily deduped as well.
`npm update` after unpinning
2 participants
Summary
We were pinning deps to partially mimic the published npm-shrinkwrap.json for package managers like yarn and pnpm that don't support it.
Since we stopped shipping the shrinkwrap in #8163, the pinning is no longer relevant.
This will help users' dependency trees get deduped much further.