fix: Handling of no-store was flipped

stephanschuler · stephanschuler · commit b4336987e8a7 · 2025-07-11T14:48:46.000+02:00
The internal state variable of $storeResponse was calculated
correctly, but the response got stored to cachen when
$storeResponse===false.

Related: VCLOUD-513
diff --git a/Classes/Service/ConsumerBackend.php b/Classes/Service/ConsumerBackend.php
@@ -280,7 +280,7 @@ protected function requestJson(Uri $uri): PromiseInterface
             $response = $this
                 ->fetch($uri, $headers)
                 ->then(function(string $result) use ($cacheIdentifier, $storeResponse) {
-                    if (!$storeResponse) {
+                    if ($storeResponse) {
                         $this->requestsCache->set($cacheIdentifier, $result);
                     }
                     return $result;

Original file line number	Diff line number	Diff line change
`@@ -280,7 +280,7 @@ protected function requestJson(Uri $uri): PromiseInterface`
`280`	`280`	`$response = $this`
`281`	`281`	`->fetch($uri, $headers)`
`282`	`282`	`->then(function(string $result) use ($cacheIdentifier, $storeResponse) {`
`283`		`- if (!$storeResponse) {`
	`283`	`+ if ($storeResponse) {`
`284`	`284`	`$this->requestsCache->set($cacheIdentifier, $result);`
`285`	`285`	`}`
`286`	`286`	`return $result;`