Merge pull request #23 from netlogix/fix/php-deprecations

fix: Remove php deprecations

Author: stephanschuler

.github/workflows/functionaltests.yml

@@ -10,7 +10,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        php-version: [ 8.1, 8.2 ]
+        php-version: [ 8.1, 8.2, 8.3 ]
         flow-version: [ 8.3 ]
         mysql-version: [5.7]
 

.github/workflows/unittests.yml

@@ -10,7 +10,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        php-version: [ 8.1, 8.2 ]
+        php-version: [ 8.1, 8.2, 8.3 ]
         flow-version: [ 8.3 ]
 
     env:

Classes/Domain/Model/ResourceProxy.php

@@ -48,37 +48,37 @@ public function setPayload($payload = [])
     /**
      * @inheritdoc
      */
-    public function offsetExists($propertyName)
+    public function offsetExists(mixed $offset): bool
     {
-        return $this->type->getPropertyDefinition($propertyName) !== Type::PROPERTY_UNDEFINED;
+        return $this->type->getPropertyDefinition($offset) !== Type::PROPERTY_UNDEFINED;
     }
 
     /**
      * @inheritdoc
      */
-    public function offsetGet($propertyName)
+    public function offsetGet(mixed $offset): mixed
     {
-        switch ($this->type->getPropertyDefinition($propertyName)) {
+        switch ($this->type->getPropertyDefinition($offset)) {
             case Type::PROPERTY_ATTRIBUTE:
-                return $this->getAttribute($propertyName);
+                return $this->getAttribute($offset);
             case Type::PROPERTY_SINGLE_RELATIONSHIP:
-                return $this->getSingleRelationship($propertyName);
+                return $this->getSingleRelationship($offset);
             case Type::PROPERTY_COLLECTION_RELATIONSHIP:
-                return $this->getCollectionRelationship($propertyName);
+                return $this->getCollectionRelationship($offset);
         }
     }
 
     /**
      * @inheritdoc
      */
-    public function offsetSet($propertyName, $value)
+    public function offsetSet(mixed $offset, mixed $value): void
     {
     }
 
     /**
      * @inheritdoc
      */
-    public function offsetUnset($propertyName)
+    public function offsetUnset(mixed $offset): void
     {
     }
 

Classes/Domain/Model/ResourceProxyIterator.php

@@ -3,6 +3,7 @@
 
 namespace Netlogix\JsonApiOrg\Consumer\Domain\Model;
 
+use Generator;
 use Neos\Cache\Frontend\VariableFrontend;
 use Neos\Flow\Cache\CacheManager;
 use Neos\Flow\Utility\Now;
@@ -85,9 +86,9 @@ public function withJsonResult(array $jsonResult): self
     }
 
     /**
-     * @return \Generator
+     * @return Generator
      */
-    public function getIterator()
+    public function getIterator(): Generator
     {
         yield from $this->data;
     }
@@ -100,7 +101,7 @@ public function getArrayCopy(): array
     /**
      * @return int
      */
-    public function count()
+    public function count(): int
     {
         if (isset($this->jsonResult)
             && array_key_exists('meta', $this->jsonResult)