feat: Prevent in-memory storing when "Cache-Control: no-store" is used as request header

Precondition 1:

There are two different caches: The request cache and the response cache.

The respones cache can utilize the response data, which allows for tagging
cache entries and hence fine grained retention calculation, so the request
cache can be used across different PHP processes and potentially across
different users.

The request cache can only utlize what's known before the request was
made. We usually use a transient memory cache for requests. This allows
a single PHP process to issue the same GET request multiple times without
needing to flush anything, because the cache content gets dropped as soon
as the PHP process is over.

Precondition 2:

Requests not only transport their URI but an array of request heraders
as well. Those request headers are meant to pass to the upstream server.
Usually, request headers are part of the response cache header, so
different request header values might cause cache misses e.g. for
basic auth.

Feature:

The request mechanism now prevents the "request cache" (as of
the second section above) to be used at all.

Author: stephanschuler

Classes/Service/ConsumerBackend.php

@@ -27,6 +27,8 @@
 use Psr\Http\Message\ResponseInterface;
 use Psr\Http\Message\UriInterface;
 
+use function strtolower;
+
 /**
  * @Flow\Scope("singleton")
  */
@@ -256,10 +258,18 @@ protected function requestJson(Uri $uri): PromiseInterface
         $uriString = (string)$uri;
 
         $headers = $this->getRequestHeaders($uriString);
+
         $headersForCacheIdentifier = [];
+        $storeResponse = true;
+
         foreach ($headers as $key => $value) {
+            $key = strtolower($key);
+            if ($key === 'cache-control' && strtolower($value) === 'no-store') {
+                $storeResponse = false;
+            }
             $headersForCacheIdentifier[] = sprintf('%s: %s', $key, $value);
         }
+
         $cacheIdentifier = md5(serialize($headersForCacheIdentifier) . '|' . $uriString);
 
         if ($this->requestsCache->has($cacheIdentifier)) {
@@ -269,8 +279,10 @@ protected function requestJson(Uri $uri): PromiseInterface
         } else {
             $response = $this
                 ->fetch($uri, $headers)
-                ->then(function(string $result) use ($cacheIdentifier) {
-                    $this->requestsCache->set($cacheIdentifier, $result);
+                ->then(function(string $result) use ($cacheIdentifier, $storeResponse) {
+                    if (!$storeResponse) {
+                        $this->requestsCache->set($cacheIdentifier, $result);
+                    }
                     return $result;
                 });
         }