fixed PHPStan errors

Author: dg

composer.json

@@ -25,6 +25,7 @@
 	},
 	"require-dev": {
 		"nette/application": "^3.2",
+		"nette/assets": "^1.0",
 		"nette/caching": "^3.2",
 		"nette/database": "^3.2",
 		"nette/forms": "^3.2",

phpstan.neon

@@ -1,8 +1,19 @@
 parameters:
-	level: 5
+	level: 8
 
 	paths:
 		- src
 
-includes:
-	- vendor/phpstan/phpstan-nette/extension.neon
+	excludePaths:
+		- src/Configurator.php  # backward compatibility shim
+
+	ignoreErrors:
+		-   # false positives guaranteed at runtime:
+			#   - InstalledVersions::getVersion() is non-null after isInstalled() check
+			#   - ClassLoader is always a user-land class with a file (2x)
+			identifier: argument.type
+			path: src/Bootstrap/Configurator.php
+			count: 3
+		-   # ClassLoader is always a user-land class with a file
+			identifier: method.nameCase
+			path: src/Bootstrap/Configurator.php

src/Bootstrap/Configurator.php

@@ -188,8 +188,8 @@ protected function getDefaultParameters(): array
 		$loaderRc = class_exists(ClassLoader::class)
 			? new \ReflectionClass(ClassLoader::class)
 			: null;
-		$rootDir = class_exists(InstalledVersions::class) && ($tmp = InstalledVersions::getRootPackage()['install_path'] ?? null)
-			? rtrim(Nette\Utils\FileSystem::normalizePath($tmp), '\/')
+		$rootDir = class_exists(InstalledVersions::class)
+			? rtrim(Nette\Utils\FileSystem::normalizePath(InstalledVersions::getRootPackage()['install_path']), '\/')
 			: null;
 		$baseUrl = new Statement('trim($this->getByType(?)->getUrl()->getBaseUrl(), "/")', [Nette\Http\IRequest::class]);
 		return [

src/Bootstrap/Extensions/ConstantsExtension.php

@@ -27,7 +27,7 @@ public function getConfigSchema(): Nette\Schema\Schema
 
 	public function loadConfiguration(): void
 	{
-		foreach ($this->getConfig() as $name => $value) {
+		foreach ((array) $this->config as $name => $value) {
 			$this->initialization->addBody('define(?, ?);', [$name, $value]);
 		}
 	}

src/Bootstrap/Extensions/PhpExtension.php

@@ -27,7 +27,7 @@ public function getConfigSchema(): Nette\Schema\Schema
 
 	public function loadConfiguration(): void
 	{
-		foreach ($this->getConfig() as $name => $value) {
+		foreach ((array) $this->config as $name => $value) {
 			if (!function_exists('ini_set')) {
 				throw new Nette\NotSupportedException('Required function ini_set() is disabled.');
 			}