BaseControl::setAttribute() and setType() marked as deprecated

Author: dg

src/Forms/Controls/BaseControl.php

@@ -330,18 +330,18 @@ public function getHtmlId(): string
 	 */
 	public function setHtmlAttribute(string $name, $value = TRUE)
 	{
-		return $this->setAttribute($name, $value);
+		$this->control->$name = $value;
+		return $this;
 	}
 
 
 	/**
-	 * Alias for setHtmlAttribute()
+	 * @deprecated  use setHtmlAttribute()
 	 * @return static
 	 */
 	public function setAttribute(string $name, $value = TRUE)
 	{
-		$this->control->$name = $value;
-		return $this;
+		return $this->setHtmlAttribute($name, $value);
 	}
 
 

src/Forms/Controls/TextInput.php

@@ -46,18 +46,18 @@ public function loadHttpData()
 	 */
 	public function setHtmlType(string $type)
 	{
-		return $this->setType($type);
+		$this->control->type = $type;
+		return $this;
 	}
 
 
 	/**
-	 * Alias for setHtmlType()
+	 * @deprecated  use setHtmlType()
 	 * @return static
 	 */
 	public function setType(string $type)
 	{
-		$this->control->type = $type;
-		return $this;
+		return $this->setHtmlType($type);
 	}