phpstan fixes

Author: dg

phpstan.neon

@@ -37,6 +37,15 @@ parameters:
 			path: src/Forms/Controls/SubmitButton.php
 			count: 1
 
+		-   # isSameSite() exists on the Nette\Http\Request implementation but the IRequest
+			# interface does not declare it (it is deprecated there in favour of isFrom()).
+			# We deliberately keep calling isSameSite() for compatibility with older nette/http
+			# ^3.3 releases where isFrom() does not yet exist.
+			identifier: method.notFound
+			message: '#^Call to an undefined method Nette\\Http\\IRequest::isSameSite\(\)\.$#'
+			path: src/Forms/Form.php
+			count: 1
+
 		-   # Nette\Forms\Control interface is intentionally minimal and missing common methods
 			# (getControl, getLabel, getForm, getOption, setOption, getHtmlName, getName, getParent,
 			# lookupPath, hasErrors, isRequired, isFilled, isDisabled, addError). In practice all
@@ -130,6 +139,7 @@ parameters:
 			# for better type safety - the contravariance is by design.
 			identifier: method.childParameterType
 			message: '#^Parameter \#1 \$value \([^)]+\) of method Nette\\Forms\\Controls\\\w+::setValue\(\) should be contravariant with parameter \$value \(mixed\) of method Nette\\Forms\\(Control|Controls\\BaseControl)::setValue\(\)$#'
+			path: src/Forms/Controls
 
 		-   # Rules::getCallback() returns callable-array [class, method] without value type.
 			message: '#^Method Nette\\Forms\\Rules::getCallback\(\) return type has no value type specified in iterable type array\.$#'

src/Forms/Controls/CsrfProtection.php

@@ -35,9 +35,7 @@ public function __construct(string|Stringable|null $errorMessage = null)
 
 		$this->monitor(Presenter::class, function (Presenter $presenter): void {
 			if (!$this->session) {
-				$session = $presenter->getSession();
-				assert($session instanceof Nette\Http\Session);
-				$this->session = $session;
+				$this->session = $presenter->getSession();
 				$this->session->start();
 			}
 		});

src/Forms/Form.php

@@ -308,8 +308,12 @@ public function allowCrossOrigin(): void
 	public function addProtection(?string $errorMessage = null): Controls\CsrfProtection
 	{
 		$control = new Controls\CsrfProtection($errorMessage);
-		$children = $this->getComponents();
-		$first = $children ? (string) array_key_first($children) : null;
+		$first = null;
+		foreach ($this->getComponents() as $name => $component) {
+			$first = (string) $name;
+			break;
+		}
+
 		$this->addComponent($control, self::ProtectorId, $first);
 		return $control;
 	}

src/Forms/Rendering/DefaultFormRenderer.php

@@ -490,6 +490,7 @@ public function renderControl(Nette\Forms\Control $control): Html
 
 		if ($nextTo = $control->getOption('nextTo')) {
 			$control = $control->getForm()->getComponent($nextTo);
+			assert($control instanceof Nette\Forms\Control);
 			$body->class($this->getValue('control .multi'), true);
 			goto renderControl;
 		}