FileMock: fread/fwrite in writeonly/readonly modes return false and trigger notices in PHP 7.4

Author: dg

src/Framework/FileMock.php

@@ -93,10 +93,10 @@ public function stream_open(string $path, string $mode): bool
 	}
 
 
-	public function stream_read(int $length): string
+	public function stream_read(int $length)
 	{
 		if (!$this->isReadable) {
-			return '';
+			return false;
 		}
 
 		$result = substr($this->content, $this->readingPos, $length);
@@ -106,10 +106,10 @@ public function stream_read(int $length): string
 	}
 
 
-	public function stream_write(string $data): int
+	public function stream_write(string $data)
 	{
 		if (!$this->isWritable) {
-			return 0;
+			return false;
 		}
 
 		$length = strlen($data);

tests/Framework/FileMock.phpt

@@ -101,13 +101,13 @@ test(function () {
 	$cases = [
 		'r' => ['ABC', 'ABC'],
 		'r+' => ['ABC', 'ABC'],
-		'w' => ['', ''],
+		'w' => ['', PHP_VERSION_ID < 70400 ? '' : false],
 		'w+' => ['', ''],
-		'a' => ['ABC', ''],
+		'a' => ['ABC', PHP_VERSION_ID < 70400 ? '' : false],
 		'a+' => ['ABC', 'ABC'],
-		'x' => ['', ''],
+		'x' => ['', PHP_VERSION_ID < 70400 ? '' : false],
 		'x+' => ['', ''],
-		'c' => ['ABC', ''],
+		'c' => ['ABC', PHP_VERSION_ID < 70400 ? '' : false],
 		'c+' => ['ABC', 'ABC'],
 	];
 
@@ -129,13 +129,13 @@ test(function () {
 	$cases = [
 		'r' => ['ABC', 'ABC'],
 		'r+' => ['_BC', '_BC'],
-		'w' => ['_', ''],
+		'w' => ['_', PHP_VERSION_ID < 70400 ? '' : false],
 		'w+' => ['_', '_'],
-		'a' => ['ABC_', ''],
+		'a' => ['ABC_', PHP_VERSION_ID < 70400 ? '' : false],
 		'a+' => ['ABC_', 'ABC_'],
-		'x' => ['_', ''],
+		'x' => ['_', PHP_VERSION_ID < 70400 ? '' : false],
 		'x+' => ['_', '_'],
-		'c' => ['_BC', ''],
+		'c' => ['_BC', PHP_VERSION_ID < 70400 ? '' : false],
 		'c+' => ['_BC', '_BC'],
 	];
 
@@ -237,20 +237,20 @@ test(function () {
 		Assert::same(ftell($handleReal), ftell($handleMock));
 		Assert::same(file_get_contents($pathReal), file_get_contents($pathMock));
 
-		Assert::same(fwrite($handleReal, 'World'), fwrite($handleMock, 'World'));
+		Assert::same(@fwrite($handleReal, 'World'), fwrite($handleMock, 'World')); // @ - triggers E_NOTICE since PHP 7.4
 		Assert::same(ftell($handleReal), ftell($handleMock));
 		Assert::same(file_get_contents($pathReal), file_get_contents($pathMock));
 
 		Assert::same(ftruncate($handleReal, 2), ftruncate($handleMock, 2));
 		Assert::same(ftell($handleReal), ftell($handleMock));
 		Assert::same(file_get_contents($pathReal), file_get_contents($pathMock));
 
-		Assert::same(fwrite($handleReal, 'World'), fwrite($handleMock, 'World'));
+		Assert::same(@fwrite($handleReal, 'World'), fwrite($handleMock, 'World')); // @ - triggers E_NOTICE since PHP 7.4
 		Assert::same(ftell($handleReal), ftell($handleMock));
 		Assert::same(file_get_contents($pathReal), file_get_contents($pathMock));
 
 		Assert::same(fseek($handleReal, 2), fseek($handleMock, 2));
-		Assert::same(fread($handleReal, 7), fread($handleMock, 7));
+		Assert::same(@fread($handleReal, 7), fread($handleMock, 7)); // @ - triggers E_NOTICE since PHP 7.4
 		Assert::same(fclose($handleReal), fclose($handleMock));
 	}