Use native clamp function inside util#337
Closed
jnoordsij wants to merge 1 commit intonette:masterfrom
Closed
Conversation
Member
|
There must be a version check using PHP_VERSION_ID. |
Author
|
That's why I've also added the (Symfony) polyfill; it is setup to provide the function if not natively available. I must admit the PR description was slightly short and did not clarify this entirely, but as such it should work fine both on current and future PHP versions. |
Member
|
🤦♂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the manual
clampimplementation with the PHP nativeclamp, which is new in PHP 8.6 (unreleased). See also:clampfunction symfony/polyfill#554Note that the only behavioral change is the type of exception and corresponding message. Migrating towards the new PHP native one seems like a reasonable choice to me, but if preferable I'm fine with catching it and manually throwing the old one.