Get rid of unnecessary .keys()

Author: The-Compiler

nuts/base_tests/napalm_get_users.py

@@ -52,4 +52,4 @@ def test_privilege_level(self, single_result, username, level):
 class TestNapalmOnlyDefinedUsersExist:
     @pytest.mark.nuts("host,usernames")
     def test_no_rogue_users(self, single_result, usernames):
-        assert list(single_result.result.keys()) == usernames
+        assert list(single_result.result) == usernames

nuts/base_tests/napalm_network_instances.py

@@ -45,7 +45,7 @@ def _extract_route_distinguisher(self, element: dict) -> str:
         return element["state"]["route_distinguisher"]
 
     def _extract_interfaces(self, element: dict) -> List[str]:
-        return list(element["interfaces"]["interface"].keys())
+        return list(element["interfaces"]["interface"])
 
 
 CONTEXT = NetworkInstancesContext

tests/base_tests/test_napalm_bgp_neighbors.py

@@ -81,7 +81,7 @@ def test_contains_hosts_at_toplevel(self, transformed_result, host):
 
     @pytest.mark.parametrize("host, neighbors", [("R1", ["172.16.255.2", "172.16.255.3"]), ("R2", ["172.16.255.1"])])
     def test_contains_peers_at_second_level(self, transformed_result, host, neighbors):
-        assert list(transformed_result[host].result.keys()) == neighbors
+        assert list(transformed_result[host].result) == neighbors
 
     @pytest.mark.parametrize("host, neighbor, details", [("R1", "172.16.255.2", neighbor_details)])
     def test_contains_information_about_neighbor(self, transformed_result, host, neighbor, details):

tests/base_tests/test_napalm_interfaces.py

@@ -74,7 +74,7 @@ def test_contains_host_at_toplevel(self, transformed_result, host):
         [("R1", "GigabitEthernet1"), ("R1", "GigabitEthernet2"), ("R2", "Loopback0"), ("R2", "GigabitEthernet3")],
     )
     def test_contains_interface_names_at_second_level(self, transformed_result, host, interface_name):
-        assert interface_name in transformed_result[host].result.keys()
+        assert interface_name in transformed_result[host].result
 
     @pytest.mark.parametrize(
         "host, name, is_enabled, is_up, mac_address",

tests/base_tests/test_napalm_lldp_neighbors.py

@@ -86,7 +86,7 @@ def test_contains_hosts_at_toplevel(self, transformed_result, host):
         [("R1", ["GigabitEthernet4", "GigabitEthernet3"]), ("R2", ["GigabitEthernet4", "GigabitEthernet2"])],
     )
     def test_contains_results_with_ports_at_second_level(self, transformed_result, host, local_ports):
-        assert list(transformed_result[host].result.keys()) == local_ports
+        assert list(transformed_result[host].result) == local_ports
 
     @pytest.mark.parametrize(
         "host, local_ports",

tests/base_tests/test_napalm_network_instances.py

@@ -87,7 +87,7 @@ def test_contains_hosts_at_toplevel(self, transformed_result, host):
         "host, network_instances", [("R1", ["default", "mgmt", "test", "test2"]), ("R2", ["default", "mgmt"])]
     )
     def test_contains_network_instances_at_second_level(self, transformed_result, host, network_instances):
-        assert list(transformed_result[host].result.keys()) == network_instances
+        assert list(transformed_result[host].result) == network_instances
 
     @pytest.mark.parametrize(
         "host, network_instance, interfaces",

tests/base_tests/test_netmiko_cdp_neighbors.py

@@ -96,7 +96,7 @@ def test_contains_hosts_at_toplevel(self, transformed_result, host):
         ],
     )
     def test_contains_neighbors_at_second_level(self, transformed_result, host, network_instances):
-        assert list(transformed_result[host].result.keys()) == network_instances
+        assert list(transformed_result[host].result) == network_instances
 
     @pytest.mark.parametrize("host, neighbor, details", [("R1", "R2", neighbor_details)])
     def test_contains_information_about_neighbor(self, transformed_result, host, neighbor, details):

tests/base_tests/test_netmiko_ospf_neighbors.py

@@ -89,7 +89,7 @@ def test_contains_hosts_at_toplevel(self, transformed_result, host):
         ],
     )
     def test_contains_neighbors_at_second_level(self, transformed_result, host, network_instances):
-        assert list(transformed_result[host].result.keys()) == network_instances
+        assert list(transformed_result[host].result) == network_instances
 
     @pytest.mark.parametrize("host, neighbor, details", [("R1", "172.16.255.3", neighbor_details)])
     def test_contains_information_about_neighbor(self, transformed_result, host, neighbor, details):

tests/showcase/showcase_expanse.py

@@ -48,7 +48,7 @@ def expanse(nuts_ctx: NutsContext, ship):
 class TestExpanseCrew:
     @pytest.mark.nuts("ship, name")
     def test_name(self, expanse: Dict, name):
-        assert name in expanse.keys()
+        assert name in expanse
 
     @pytest.mark.nuts("ship, name, role")
     def test_role(self, expanse: Dict, name, role):