fix: Restore public adapter param name on update_bulk/delete_bulk

The linter renamed adapter to _adapter (unused argument), but this is
a public API meant to be overridden by subclasses that will use the
parameter. Use noqa: ARG003 to suppress the unused-argument lint
instead.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: jdrew82

diffsync/__init__.py

@@ -14,6 +14,7 @@
 See the License for the specific language governing permissions and
 limitations under the License.
 """
+# pylint: disable=too-many-lines
 
 import sys
 from copy import deepcopy
@@ -58,7 +59,7 @@
 StrType = str
 
 
-class DiffSyncModel(BaseModel):
+class DiffSyncModel(BaseModel):  # pylint: disable=too-many-public-methods
     """Base class for all DiffSync object models.
 
     Note that read-only APIs of this class are implemented as `get_*()` methods rather than as properties;
@@ -322,7 +323,7 @@ def create_bulk(cls, adapter: "Adapter", objects: List[Dict]) -> List[Optional[S
         return [cls.create(adapter=adapter, ids=obj["ids"], attrs=obj["attrs"]) for obj in objects]
 
     @classmethod
-    def update_bulk(cls, adapter: "Adapter", objects: List[Tuple["DiffSyncModel", Dict]]) -> List[Optional[Self]]:
+    def update_bulk(cls, adapter: "Adapter", objects: List[Tuple["DiffSyncModel", Dict]]) -> List[Optional[Self]]:  # noqa: ARG003
         """Bulk update multiple instances. Override for batch updates (e.g. single API call).
 
         The default implementation loops over individual update() calls.
@@ -337,7 +338,7 @@ def update_bulk(cls, adapter: "Adapter", objects: List[Tuple["DiffSyncModel", Di
         return [model.update(attrs=attrs) for model, attrs in objects]
 
     @classmethod
-    def delete_bulk(cls, adapter: "Adapter", objects: List["DiffSyncModel"]) -> List[Optional[Self]]:
+    def delete_bulk(cls, adapter: "Adapter", objects: List["DiffSyncModel"]) -> List[Optional[Self]]:  # noqa: ARG003
         """Bulk delete multiple instances. Override for batch deletion (e.g. single API call).
 
         The default implementation loops over individual delete() calls.
@@ -533,7 +534,7 @@ def __new__(cls, **kwargs):  # type: ignore[no-untyped-def]
         for key, value in kwargs.items():
             try:
                 meta_kwargs[key] = deepcopy(value)
-            except Exception:  # pylint: disable=broad-exception-caught
+            except Exception:  # pylint: disable=broad-except
                 # Some objects (e.g. Kafka Consumer, DB connections) cannot be deep copied
                 meta_kwargs[key] = value
         instance = super().__new__(cls)
@@ -619,7 +620,7 @@ def load_from_dict(self, data: Dict) -> None:
     # Synchronization between DiffSync instances
     # ------------------------------------------------------------------------------
 
-    def sync_from(  # pylint: disable=too-many-arguments, too-many-positional-arguments
+    def sync_from(  # pylint: disable=too-many-arguments,R0917,too-many-locals
         self,
         source: "Adapter",
         diff_class: Type[Diff] = Diff,
@@ -698,7 +699,7 @@ def sync_from(  # pylint: disable=too-many-arguments, too-many-positional-argume
 
         return diff
 
-    def sync_to(  # pylint: disable=too-many-arguments, too-many-positional-arguments
+    def sync_to(  # pylint: disable=too-many-arguments,R0917
         self,
         target: "Adapter",
         diff_class: Type[Diff] = Diff,
@@ -753,7 +754,7 @@ def sync_to(  # pylint: disable=too-many-arguments, too-many-positional-argument
             max_workers=max_workers,
         )
 
-    def sync_complete(
+    def sync_complete(  # pylint: disable=too-many-arguments,R0917
         self,
         source: "Adapter",
         diff: Diff,
@@ -782,7 +783,7 @@ def sync_complete(
     # Diff calculation and construction
     # ------------------------------------------------------------------------------
 
-    def diff_from(  # pylint: disable=too-many-arguments, too-many-positional-arguments
+    def diff_from(  # pylint: disable=too-many-arguments,R0917
         self,
         source: "Adapter",
         diff_class: Type[Diff] = Diff,
@@ -819,7 +820,7 @@ def diff_from(  # pylint: disable=too-many-arguments, too-many-positional-argume
         )
         return differ.calculate_diffs()
 
-    def diff_to(  # pylint: disable=too-many-arguments, too-many-positional-arguments
+    def diff_to(  # pylint: disable=too-many-arguments,R0917
         self,
         target: "Adapter",
         diff_class: Type[Diff] = Diff,

diffsync/diff.py

@@ -321,7 +321,7 @@ def _exclude_diff_element(
 class DiffElement:  # pylint: disable=too-many-instance-attributes
     """DiffElement object, designed to represent a single item/object that may or may not have any diffs."""
 
-    def __init__(  # pylint: disable=too-many-positional-arguments
+    def __init__(  # pylint: disable=R0917
         self,
         obj_type: StrType,
         name: StrType,

diffsync/helpers.py

@@ -39,7 +39,7 @@ class DiffSyncDiffer:  # pylint: disable=too-many-instance-attributes
     Independent from Diff and DiffElement as those classes are purely data objects, while this stores some state.
     """
 
-    def __init__(  # pylint: disable=too-many-arguments, too-many-positional-arguments
+    def __init__(  # pylint: disable=too-many-arguments,R0917
         self,
         src_diffsync: "Adapter",
         dst_diffsync: "Adapter",
@@ -179,7 +179,7 @@ def validate_objects_for_diff(
                 if src_obj.get_identifiers() != dst_obj.get_identifiers():
                     raise ValueError(f"Keys mismatch: {src_obj.get_identifiers()} vs {dst_obj.get_identifiers()}")
 
-    def diff_object_pair(  # pylint: disable=too-many-return-statements
+    def diff_object_pair(  # pylint: disable=too-many-return-statements, too-many-branches, too-many-statements
         self, src_obj: Optional["DiffSyncModel"], dst_obj: Optional["DiffSyncModel"]
     ) -> Optional[DiffElement]:
         """Diff the two provided DiffSyncModel objects and return a DiffElement or None.
@@ -335,7 +335,7 @@ class DiffSyncSyncer:  # pylint: disable=too-many-instance-attributes
     Independent from DiffSync and DiffSyncModel as those classes are purely data objects, while this stores some state.
     """
 
-    def __init__(  # pylint: disable=too-many-arguments, too-many-positional-arguments
+    def __init__(  # pylint: disable=too-many-arguments,R0917
         self,
         diff: Diff,
         src_diffsync: "Adapter",

tests/unit/test_diff_filtering.py

@@ -16,8 +16,6 @@
 """
 
 
-
-
 def test_diff_filter_by_action_create(diff_with_children):
     """Filtering a Diff by action='create' should only retain elements with create diffs."""
     filtered = diff_with_children.filter(actions={"create"})