Fix Arista EOS sh int tran hw detected media type#2297
Open
Mikeg2881 wants to merge 3 commits intonetworktocode:masterfrom
Open
Fix Arista EOS sh int tran hw detected media type#2297Mikeg2881 wants to merge 3 commits intonetworktocode:masterfrom
Mikeg2881 wants to merge 3 commits intonetworktocode:masterfrom
Conversation
Mikeg2881
requested review from
itdependsnetworks,
jmcgill298,
jvanderaa,
matt852 and
mjbear
as code owners
mjbear
reviewed
Mar 31, 2026
py
Outdated
Collaborator
There was a problem hiding this comment.
This "py" file should probably not be included in the PR.
mjbear
reviewed
Mar 31, 2026
Comment on lines
+11
to
+12
| - cable_type: "" | ||
|
|
Collaborator
There was a problem hiding this comment.
@Mikeg2881 There appears to be a problem with the rendered output starting at line 11. It stops at cable_type when there are several more keys that should come after that.
Please fix. Thank you!
mjbear
changed the title
mjbear
changed the title
Contributor
Author
|
@mjbear i believe i have it correct now. Not sure where that "py" file came from |
mjbear
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For issue #2290
Add detected media type to Arista EOS show interface transceiver hardware template.